Skip to content

Commit d8bc4f6

Browse files
dweindldilpath
andauthored
Apply suggestions from code review
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
1 parent d524898 commit d8bc4f6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

petab/v2/converters.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@ def _convert_experiment(self, experiment: Experiment) -> None:
248248
# Additionally, tools that don't support events can still handle
249249
# single-period experiments.
250250
if i_period == 0:
251-
exp_ind = self.get_experiment_indicator(experiment.id)
251+
exp_ind_id = self.get_experiment_indicator(experiment.id)
252252
for change in self._new_problem.get_changes_for_period(period):
253253
period0_assignments.setdefault(
254254
change.target_id, []
255-
).append((exp_ind, change.target_value))
255+
).append((exp_ind_id, change.target_value))
256256
else:
257257
ev = self._create_period_start_event(
258258
experiment=experiment,
@@ -332,7 +332,7 @@ def _convert_experiment(self, experiment: Experiment) -> None:
332332
def _initial_value_from_element(target: libsbml.SBase) -> sp.Basic:
333333
"""Get the initial value of an SBML element.
334334
335-
The value to the size attribute of compartments,
335+
The value of the size attribute of compartments,
336336
the initial concentration or amount of species (amount for
337337
`hasOnlySubstanceUnits=true`, concentration otherwise), and
338338
the value of parameters, not considering any initial assignment
@@ -530,7 +530,7 @@ def _create_event_assignments_for_period(
530530
):
531531
# Handle any changes other than compartments and
532532
# concentration-based species inside resized compartments
533-
# that we were already handled above.
533+
# that we already handled above.
534534
# Those translate directly to event assignments.
535535
_add_assignment(event, change.target_id, change.target_value)
536536

0 commit comments

Comments
 (0)