Commit 46d8d16
committed
GH Actions: change the building of the (release) PHARs to PHP 8.0
The PHP native `php_strip_whitespace()` function used in the PHAR build script is PHP version sensitive.
The function strips comments and whitespace out of the code, but in PHP 7.4, attributes are seen as comments due to the `#[]` syntax, which means that if the PHAR files were being generated on PHP 7.4, the PHP 8.1 #[ReturnTypeWillChange]` attributes as put in via PR 3400 would be stripped out.
In other words: for the PHAR files to be cross-version compatible, they *MUST* be generated on PHP 8.0 or higher.
This fixes this for the CI part of things.
Ref: https://www.php.net/manual/en/function.php-strip-whitespace.php1 parent 7d4514d commit 46d8d16
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
0 commit comments