Fixed #855

Author: Geolim4

lib/Phpfastcache/Cluster/Drivers/FullReplication/Driver.php

@@ -72,7 +72,12 @@ public function getItem(string $key): ExtendedCacheItemInterface
             }
         }
 
-        return $this->getStandardizedItem($item ?? new Item($this, $key, $this->getEventManager()), $this);
+        if ($item === null) {
+            $item = new Item($this, $key, $this->getEventManager());
+            $item->expiresAfter(abs($this->getConfig()->getDefaultTtl()));
+        }
+
+        return $this->getStandardizedItem($item, $this);
     }
 
     /**

lib/Phpfastcache/Cluster/Drivers/MasterSlaveReplication/Driver.php

@@ -26,11 +26,9 @@
 use Phpfastcache\Exceptions\PhpfastcacheDriverException;
 use Phpfastcache\Exceptions\PhpfastcacheExceptionInterface;
 use Phpfastcache\Exceptions\PhpfastcacheInvalidArgumentException;
-use Phpfastcache\Exceptions\PhpfastcacheInvalidConfigurationException;
 use Phpfastcache\Exceptions\PhpfastcacheIOException;
 use Phpfastcache\Exceptions\PhpfastcacheReplicationException;
 use Psr\Cache\CacheItemInterface;
-use ReflectionException;
 
 class Driver extends ClusterPoolAbstract
 {
@@ -61,7 +59,9 @@ public function __construct(string $clusterName, EventManager $em, ExtendedCache
     public function getItem(string $key): ExtendedCacheItemInterface
     {
         return $this->getStandardizedItem(
-            $this->makeOperation(static fn (ExtendedCacheItemPoolInterface $pool) => $pool->getItem($key)) ?? new Item($this, $key, $this->getEventManager()),
+            $this->makeOperation(static function (ExtendedCacheItemPoolInterface $pool) use ($key) {
+                return $pool->getItem($key);
+            }) ?? (new Item($this, $key, $this->getEventManager()))->expiresAfter(abs($this->getConfig()->getDefaultTtl())),
             $this
         );
     }

lib/Phpfastcache/Cluster/Drivers/RandomReplication/Driver.php

@@ -27,6 +27,7 @@ class Driver extends MasterSlaveReplicationDriver
     /**
      * RandomReplicationCluster constructor.
      * @param string $clusterName
+     * @param EventManagerInterface $em
      * @param ExtendedCacheItemPoolInterface ...$driverPools
      * @throws ReflectionException
      */

lib/Phpfastcache/Cluster/Drivers/SemiReplication/Driver.php

@@ -26,8 +26,8 @@ class Driver extends ClusterPoolAbstract
 {
     /**
      * @inheritDoc
-     * @throws PhpfastcacheReplicationException
      * @throws InvalidArgumentException
+     * @throws PhpfastcacheReplicationException
      */
     public function getItem(string $key): ExtendedCacheItemInterface
     {
@@ -51,7 +51,12 @@ public function getItem(string $key): ExtendedCacheItemInterface
             throw new PhpfastcacheReplicationException('Every pools thrown an exception');
         }
 
-        return $this->getStandardizedItem($item ?? new Item($this, $key, $this->getEventManager()), $this);
+        if ($item === null) {
+            $item = new Item($this, $key, $this->getEventManager());
+            $item->expiresAfter(abs($this->getConfig()->getDefaultTtl()));
+        }
+
+        return $this->getStandardizedItem($item, $this);
     }
 
     /**

lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php

@@ -20,17 +20,13 @@
 use Phpfastcache\Entities\DriverIO;
 use Phpfastcache\Entities\ItemBatch;
 use Phpfastcache\Event\Event;
-use Phpfastcache\Event\EventManagerDispatcherTrait;
 use Phpfastcache\Event\EventReferenceParameter;
 use Phpfastcache\Exceptions\PhpfastcacheCoreException;
 use Phpfastcache\Exceptions\PhpfastcacheDriverException;
 use Phpfastcache\Exceptions\PhpfastcacheInvalidArgumentException;
 use Phpfastcache\Exceptions\PhpfastcacheIOException;
 use Phpfastcache\Exceptions\PhpfastcacheLogicException;
-use Phpfastcache\Util\ClassNamespaceResolverTrait;
 use Psr\Cache\CacheItemInterface;
-use ReflectionClass;
-use ReflectionObject;
 use RuntimeException;
 
 trait CacheItemPoolTrait
@@ -233,7 +229,7 @@ public function getItem(string $key): ExtendedCacheItemInterface
 
             return $item;
         }
-        throw new PhpfastcacheInvalidArgumentException(\sprintf('Item %s was not build due to an unknown error', \gettype($key)));
+        throw new PhpfastcacheInvalidArgumentException(\sprintf('Item %s was not built due to an unknown error', \gettype($key)));
     }
 
     /**

lib/Phpfastcache/Drivers/Redis/Driver.php

@@ -161,10 +161,7 @@ protected function driverDelete(ExtendedCacheItemInterface $item): bool
     {
         $this->assertCacheItemType($item, Item::class);
 
-        $this->instance->del($item->getKey());
-
-        // Redis sometime returns erroneous results
-        return true;
+        return (bool) $this->instance->del($item->getKey());
     }
 
     /**

tests/ClusterFullReplication.test.php

@@ -28,7 +28,6 @@
 $clusterAggregator->aggregateDriver(CacheManager::getInstance('Files'));
 $clusterAggregator->aggregateDriver(CacheManager::getInstance('Sqlite'));
 $cluster = $clusterAggregator->getCluster(AggregatorInterface::STRATEGY_FULL_REPLICATION);
-$cluster->clear();
 
 $testHelper->runCRUDTests($cluster);