Use native Test-Path in validation scripts which can handle relative paths, add Resolve-Path to main process block

Author: DanGough

src/PSAppDeployToolkit.Tools/Public/Convert-ADTDeployment.ps1

@@ -77,15 +77,15 @@ function Convert-ADTDeployment
                 {
                     $PSCmdlet.ThrowTerminatingError((New-ADTValidateScriptErrorRecord -ParameterName Path -ProvidedValue $_ -ExceptionMessage 'The specified path does not exist.'))
                 }
-                elseif ([System.IO.File]::Exists($_) -and [System.IO.Path]::GetExtension($_) -ne '.ps1')
+                elseif ((Test-Path -LiteralPath $_ -PathType Leaf) -and [System.IO.Path]::GetExtension($_) -ne '.ps1')
                 {
                     $PSCmdlet.ThrowTerminatingError((New-ADTValidateScriptErrorRecord -ParameterName Path -ProvidedValue $_ -ExceptionMessage 'The specified file is not a PowerShell script.'))
                 }
-                elseif ([System.IO.Directory]::Exists($_) -and -not [System.IO.File]::Exists([System.IO.Path]::Combine($_, 'Deploy-Application.ps1')))
+                elseif ((Test-Path -LiteralPath $_ -PathType Container) -and -not (Test-Path -LiteralPath (Join-Path -Path $_ -ChildPath 'Deploy-Application.ps1') -PathType Leaf))
                 {
                     $PSCmdlet.ThrowTerminatingError((New-ADTValidateScriptErrorRecord -ParameterName Path -ProvidedValue $_ -ExceptionMessage 'Deploy-Application.ps1 not found in the specified path.'))
                 }
-                elseif ([System.IO.Directory]::Exists($_) -and -not [System.IO.Directory]::Exists([System.IO.Path]::Combine($_, 'AppDeployToolkit')))
+                elseif ((Test-Path -LiteralPath $_ -PathType Container) -and -not (Test-Path -LiteralPath (Join-Path -Path $_ -ChildPath 'AppDeployToolkit') -PathType Container))
                 {
                     $PSCmdlet.ThrowTerminatingError((New-ADTValidateScriptErrorRecord -ParameterName Path -ProvidedValue $_ -ExceptionMessage 'AppDeployToolkit folder not found in the specified path.'))
                 }
@@ -139,6 +139,7 @@ function Convert-ADTDeployment
         {
             try
             {
+                $Path = (Resolve-Path -LiteralPath $Path).Path
                 $tempFolderName = "Convert-ADTDeployment_$([System.IO.Path]::GetRandomFileName().Replace('.', ''))"
                 $tempFolderPath = [System.IO.Path]::Combine([System.IO.Path]::GetTempPath(), $tempFolderName)
 

src/PSAppDeployToolkit.Tools/Public/Test-ADTCompatibility.ps1

@@ -65,7 +65,7 @@ function Test-ADTCompatibility
         [Parameter(Mandatory = $true, ValueFromPipeline = $true, ValueFromPipelineByPropertyName = $true)]
         [Alias('FullName')]
         [ValidateScript({
-                if (![System.IO.File]::Exists($_))
+                if (!(Test-Path -LiteralPath $_ -PathType Leaf))
                 {
                     $PSCmdlet.ThrowTerminatingError((New-ADTValidateScriptErrorRecord -ParameterName FilePath -ProvidedValue $_ -ExceptionMessage 'The specified file does not exist.'))
                 }
@@ -92,6 +92,8 @@ function Test-ADTCompatibility
         {
             try
             {
+                $FilePath = (Resolve-Path -LiteralPath $FilePath).Path
+
                 if ($FilePath -notmatch '(Deploy-Application\.ps1|Invoke-AppDeployToolkit\.ps1)$')
                 {
                     Write-Warning -Message "This function is designed to test PSAppDeployToolkit deployment scripts such as Deploy-Application.ps1 or Invoke-AppDeployToolkit.ps1."