Skip to content

Commit 6772aca

Browse files
Update according Yi's comments
- Put the 'ARG DEBIAN_FRONTEND=noninteractive' ahead of the first 'apt-get install' invoke. - Add comments to Dockerfiles to explain why we're adding Bazel installation. Signed-off-by: Li Peng <lipeng@unisound.com>
1 parent 0592d1b commit 6772aca

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

paddle/scripts/docker/Dockerfile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
FROM ubuntu:14.04
22
MAINTAINER PaddlePaddle Authors <paddle-dev@baidu.com>
33

4+
ARG DEBIAN_FRONTEND=noninteractive
45
RUN apt-get update \
56
&& apt-get install -y cmake libprotobuf-dev protobuf-compiler git \
67
libgoogle-glog-dev libgflags-dev libatlas-dev libatlas3-base g++ m4 python-pip \
@@ -12,7 +13,11 @@ RUN apt-get update \
1213
RUN pip install -U BeautifulSoup docopt PyYAML pillow \
1314
sphinx sphinx_rtd_theme breathe recommonmark
1415

15-
ARG DEBIAN_FRONTEND=noninteractive
16+
# cmake tends to hide and blur the dependencies between code modules, as
17+
# noted here https://github.com/PaddlePaddle/Paddle/issues/763. We are
18+
# thinking about using Bazel to fix this problem, e.g.,
19+
# https://github.com/PaddlePaddle/Paddle/issues/681#issuecomment-263996102. To
20+
# start the trail of fixing, we add Bazel to our Dockerfiles.
1621
RUN apt-get update && apt-get install -y curl software-properties-common \
1722
&& add-apt-repository ppa:webupd8team/java \
1823
&& echo "oracle-java8-installer shared/accepted-oracle-license-v1-1 select true" | debconf-set-selections \

paddle/scripts/docker/Dockerfile.gpu

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
FROM nvidia/cuda:7.5-cudnn5-devel-ubuntu14.04
22
MAINTAINER PaddlePaddle Authors <paddle-dev@baidu.com>
33

4+
ARG DEBIAN_FRONTEND=noninteractive
45
RUN apt-get update \
56
&& apt-get install -y cmake libprotobuf-dev protobuf-compiler git \
67
libgoogle-glog-dev libgflags-dev libatlas-dev libatlas3-base g++ m4 python-pip \
@@ -12,7 +13,11 @@ RUN apt-get update \
1213
RUN pip install -U BeautifulSoup docopt PyYAML pillow \
1314
sphinx sphinx_rtd_theme breathe recommonmark
1415

15-
ARG DEBIAN_FRONTEND=noninteractive
16+
# cmake tends to hide and blur the dependencies between code modules, as
17+
# noted here https://github.com/PaddlePaddle/Paddle/issues/763. We are
18+
# thinking about using Bazel to fix this problem, e.g.,
19+
# https://github.com/PaddlePaddle/Paddle/issues/681#issuecomment-263996102. To
20+
# start the trail of fixing, we add Bazel to our Dockerfiles.
1621
RUN apt-get update && apt-get install -y curl software-properties-common \
1722
&& add-apt-repository ppa:webupd8team/java \
1823
&& echo "oracle-java8-installer shared/accepted-oracle-license-v1-1 select true" | debconf-set-selections \

0 commit comments

Comments
 (0)