moi curvilinear `pset_execute_2d` and `pset_execute_3d` benchmark failure

[fluidnumerics-joe]

Parcels version

Parcels-code/Parcels@32bcf93 (v4-dev branch)

Steps to reproduce

pixi run asv run

Error message

Example error message shown below for the time_pset_execute_3d benchmark

[100.00%] ··· ============== =============
              --             chunk / npart
              -------------- -------------
               interpolator   256 / 10000 
              ============== =============
                 XLinear         failed   
              ============== =============
              For parameters: 'XLinear', 256, 10000
              Traceback (most recent call last):
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/server.py", line 179, in _run_server
                  _run(run_args)
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/run.py", line 72, in _run
                  result = benchmark.do_run()
                           ^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/benchmarks/_base.py", line 661, in do_run
                  return self.run(*self._current_params)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/benchmarks/time.py", line 165, in run
                  samples, number = self.benchmark_timing(
                                    ^^^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/benchmarks/time.py", line 258, in benchmark_timing
                  timing = timer.timeit(number)
                           ^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/timeit.py", line 180, in timeit
                  timing = self.inner(it, self.timer)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "<timeit-src>", line 6, in inner
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/asv_runner/benchmarks/time.py", line 90, in func
                  self.func(*param)
                File "/group/tdgs/joe/parcels-benchmarks/benchmarks/moi_curvilinear.py", line 102, in time_pset_execute_3d
                  self.pset_execute_3d(interpolator,chunk,npart)
                File "/group/tdgs/joe/parcels-benchmarks/benchmarks/moi_curvilinear.py", line 84, in pset_execute_3d
                  U = parcels.Field("U", ds["U"], grid, interp_method=interp_method)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/_core/field.py", line 119, in __init__
                  raise e
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/_core/field.py", line 114, in __init__
                  self.time_interval = _get_time_interval(data)
                                       ^^^^^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/_core/field.py", line 448, in _get_time_interval
                  return TimeInterval(data.time.values[0], data.time.values[-1])
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/group/tdgs/joe/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/_core/utils/time.py", line 42, in __init__
                  raise ValueError(f"Expected left to be strictly less than right, got left={left} and right={right}.")
              ValueError: Expected left to be strictly less than right, got left=2025-01-03T12:00:00.000000000 and right=2025-01-01T12:00:00.000000000.
              Error getting time interval for field 'U'. Are you sure that the time dimension on the xarray dataset is stored as timedelta, datetime or cftime datetime objects?

[VeckoTheGecko]

Hi Joe, I tried recreating this - but I don't know which branch of parcels-benchmarks you're working from :/ . I don't get the same errors

Working from main I got the following errors.

   ImportError: cannot import name 'UxPiecewiseConstantFace' from 'parcels.interpolators' (/private/tmp/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/interpolators/__init__.py)

   ImportError: cannot import name 'Geographic' from 'parcels' (/private/tmp/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/__init__.py)

I've resolved these in vecko/33, and now am running into

                  UV = parcels.VectorField("UV", U, V)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                File "/private/tmp/parcels-benchmarks/.asv/env/b54e0339d4ce929e91168b1373f7b02b/lib/python3.12/site-packages/parcels/_core/field.py", line 251, in __init__
                  raise ValueError("vector_interp_method must be provided for VectorField initialization.")
              ValueError: vector_interp_method must be provided for VectorField initialization.

I should have fixed this fixed this in the week when I had more time for a back and forth, as I have to go now (and I'm away next week) . I'll take a look when I'm back in Utrecht.

[fluidnumerics-joe]

Yeah, the error you're showing is in #32 and I've gotten that mostly worked out. I'll be spending more time on this one next week.

[fluidnumerics-joe]

The parcels version I'm using is referenced in the issue description