Code analysis fixes (#884)

Author: DavidBoike

.github/workflows/ci.yml

@@ -35,7 +35,9 @@ jobs:
       - name: Setup .NET SDK
         uses: actions/setup-dotnet@v4.0.0
         with:
-          dotnet-version: 8.0.x
+          dotnet-version: |
+            8.0.x
+            6.0.x
       - name: Setup Azure Functions Core Tools - Windows
         if: runner.os == 'Windows'
         run: |

src/IntegrationTests.HostV4/.editorconfig

@@ -0,0 +1,4 @@
+[*.cs]
+
+# ConfigureAwait(false)
+dotnet_diagnostic.CA2007.severity = none

src/IntegrationTests.HostV4/GlobalSuppressions.cs

@@ -0,0 +1,13 @@
+[*.cs]
+
+# ConfigureAwait(false)
+dotnet_diagnostic.CA2007.severity = none
+
+# Use pattern matching (may change code meaning)
+dotnet_diagnostic.IDE0078.severity = none
+
+# Use pattern matching
+dotnet_diagnostic.IDE0083.severity = none
+
+# Convert switch statement to expression
+dotnet_diagnostic.IDE0066.severity = none

src/NServiceBus.AzureFunctions.Analyzer.Tests/.editorconfig

@@ -2,8 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>net6.0</TargetFramework>
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>..\NServiceBusTests.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
 
   <ItemGroup>

src/NServiceBus.AzureFunctions.Analyzer.Tests/GlobalSuppressions.cs

@@ -13,8 +13,8 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Azure.Functions.Extensions" Version="1.1.0" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.16.4" />
-    <PackageReference Include="NServiceBus.Newtonsoft.Json" Version="3.0.0" />
     <PackageReference Include="NServiceBus" Version="8.2.4" />
+    <PackageReference Include="NServiceBus.Newtonsoft.Json" Version="3.0.0" />
     <PackageReference Include="NServiceBus.Transport.AzureServiceBus" Version="3.2.5" />
     <PackageReference Include="Obsolete.Fody" Version="5.3.0" PrivateAssets="All" />
     <PackageReference Include="Particular.Packaging" Version="4.2.0" PrivateAssets="All" />
@@ -36,8 +36,8 @@
   </Target>
 
   <ItemGroup>
-    <InternalsVisibleTo Include="ServiceBus.Tests" Key="$(NServiceBusTestsKey)" />
     <InternalsVisibleTo Include="ServiceBus.AcceptanceTests" Key="$(NServiceBusTestsKey)" />
+    <InternalsVisibleTo Include="ServiceBus.Tests" Key="$(NServiceBusTestsKey)" />
   </ItemGroup>
 
 </Project>