Revert "Moved TrySetResult to loop so that both TrySetResult and TrySetException are managed in the same code"

This reverts commit 251f167.

Author: ramonsmits

src/ServiceControl.Audit/Auditing/AuditIngestion.cs

@@ -235,16 +235,6 @@ async Task Loop(CancellationToken cancellationToken)
                         auditBatchSize.Record(contexts.Count);
 
                         await auditIngestor.Ingest(contexts, cancellationToken);
-
-                        foreach (var context in contexts)
-                        {
-                            // Some items that faulted could already have been set
-                            if (!context.GetTaskCompletionSource().TrySetResult(true))
-                            {
-                                logger.Warn("TrySetResult failed");
-                            }
-                        }
-
                         auditBatchDuration.Record(sw.ElapsedMilliseconds);
 
                         // No locking for consistency needed, just write, don't care about multi-threading

src/ServiceControl.Audit/Auditing/AuditIngestor.cs

@@ -66,6 +66,14 @@ public async Task Ingest(List<MessageContext> contexts, CancellationToken cancel
                         Log.Debug("Forwarded messages");
                     }
                 }
+
+                foreach (var context in contexts)
+                {
+                    if (!context.GetTaskCompletionSource().TrySetResult(true))
+                    {
+                        Log.Warn("TrySetResult failed");
+                    }
+                }
             }
             catch (Exception e)
             {