Logging uses NLog, Extensions.Logging and NServiceBus.Logging

[ramonsmits]

Describe the suggested improvement

Is your improvement related to a problem? Please describe.

Logging uses NLog, Extensions.Logging and NServiceBus.Logging

Describe the suggested solution

Microsoft.Extensions.Logging

Logging can be improved by just using a single logging API, preferably Microsoft.Extensions.Logging so all logging for ServiceControl code is unified.

Bootstrap logger

To prevent needing to use NLog directly logging can use a "bootstrap logger" for early logging before the host isn't fully initialized. For example to ensure that any issues with settings and specifically configuration of logging is also logged.

Additional Context

No response

[PhilBastian]

#5000 converts all log statements to use Microsoft.Extensions.Logging, injected where possible, and also keeps NLog directly for bootstrap logging. This can potentially be enhanced further using a framework that directly supports bootstrap logging, e.g. Serilog, but the immediate issue has been addressed

[snakefoot]

using a framework that directly supports bootstrap logging, e.g. Serilog

Notice that most logging frameworks supports creating an isolated-logger, which can be used until Host-Build-completed.

Microsoft Extension Logging

using ILoggerFactory factory = LoggerFactory.Create(builder => builder.AddConsole());
var logger = factory.CreateLogger("Program");
logger.LogInformation("Hello World!");

NLog with Microsoft Extension Logging

using ILoggerFactory factory = LoggerFactory.Create(builder => builder.AddNLog(svc => new LogFactory().Setup().LoadConfiguration(cfg => {
     cfg.ForLogger().WriteToConsole(); 
}).LogFactory);
var logger = factory.CreateLogger("Program");
logger.LogInformation("Hello World!");

NLog without Microsoft Extension Logging

using NLog.LogFactory factory = new NLog.LogFactory().Setup().LoadConfiguration(cfg => {
     cfg.ForLogger().WriteToConsole(); 
}).LogFactory;
var logger = factory.GetLogger("Program");
logger.Info("Hello World!");