From 6e62667141c0dbb14beb8fc9e459de0133a271c2 Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Thu, 20 Mar 2025 15:16:25 +1100 Subject: [PATCH] avoid array allocations for string split --- src/ServiceControl.UnitTests/API/APIApprovals.cs | 2 +- .../ExternalIntegrations/RemoveVersionInformationBehavior.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ServiceControl.UnitTests/API/APIApprovals.cs b/src/ServiceControl.UnitTests/API/APIApprovals.cs index af4da85885..24c04d2c1e 100644 --- a/src/ServiceControl.UnitTests/API/APIApprovals.cs +++ b/src/ServiceControl.UnitTests/API/APIApprovals.cs @@ -150,7 +150,7 @@ string RemoveDataStoreSettings(string json) foreach (var settingLine in settingsLines) { - var parts = settingLine.Split(new[] { ':' }, StringSplitOptions.RemoveEmptyEntries); + var parts = settingLine.Split(':', StringSplitOptions.RemoveEmptyEntries); var settingName = parts[0].Trim('"', ' '); if (dataStoreSettings.Contains(settingName) == false) diff --git a/src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs b/src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs index 0c1035b7f6..1162632b5e 100644 --- a/src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs +++ b/src/ServiceControl/ExternalIntegrations/RemoveVersionInformationBehavior.cs @@ -11,7 +11,7 @@ public override Task Invoke(IOutgoingPhysicalMessageContext context, Func { if (context.Headers.TryGetValue(NServiceBus.Headers.EnclosedMessageTypes, out var typeHeader)) { - var types = typeHeader.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries); + var types = typeHeader.Split(';', StringSplitOptions.RemoveEmptyEntries); var typesWithoutVersionInfo = string.Join(";", types.Select(x => RemoveVersionAndKeyInformation(x)));