diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index f7ff60547d..9be60cad6f 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -52,7 +52,7 @@ - + diff --git a/src/ServiceControl.Persistence.Tests/EnsureSettingsInContainer.cs b/src/ServiceControl.Persistence.Tests/EnsureSettingsInContainer.cs index e6c3e4bf31..e77b9f2168 100644 --- a/src/ServiceControl.Persistence.Tests/EnsureSettingsInContainer.cs +++ b/src/ServiceControl.Persistence.Tests/EnsureSettingsInContainer.cs @@ -13,7 +13,7 @@ public void CheckForBothTypes() var baseSettings = ServiceProvider.GetRequiredService(); var actualType = baseSettings.GetType(); - Assert.That(typeof(PersistenceSettings), Is.Not.EqualTo(actualType)); + Assert.That(actualType, Is.Not.EqualTo(typeof(PersistenceSettings))); // Persistence implementation must also register the same singleton as the persister-specific type var settingsAsActualType = ServiceProvider.GetRequiredService(actualType); diff --git a/src/ServiceControl.Transports.Tests/FullEndpointTestFixture.cs b/src/ServiceControl.Transports.Tests/FullEndpointTestFixture.cs index c1034d05f2..0c0af7df1c 100644 --- a/src/ServiceControl.Transports.Tests/FullEndpointTestFixture.cs +++ b/src/ServiceControl.Transports.Tests/FullEndpointTestFixture.cs @@ -7,7 +7,8 @@ using ServiceControl.Infrastructure; [TestFixture] - class FullEndpointTestFixture + + abstract class FullEndpointTestFixture { [SetUp] public virtual async Task Setup() diff --git a/src/ServiceControl.Transports.Tests/TransportTestFixture.cs b/src/ServiceControl.Transports.Tests/TransportTestFixture.cs index 7dd9d6ef5d..de88f52cac 100644 --- a/src/ServiceControl.Transports.Tests/TransportTestFixture.cs +++ b/src/ServiceControl.Transports.Tests/TransportTestFixture.cs @@ -18,12 +18,13 @@ using Transports; [TestFixture] - class TransportTestFixture + + abstract class TransportTestFixture { [SetUp] public virtual async Task Setup() { - //used for loggers outside of ServiceControl (i.e. transports and core) to use the logger factory defined here + //used for loggers outside ServiceControl (i.e. transports and core) to use the logger factory defined here LogManager.UseFactory(new ExtensionsLoggerFactory(new TestContextAppenderFactory(Microsoft.Extensions.Logging.LogLevel.Warning))); LoggerUtil.ActiveLoggers = Loggers.Test; configuration = new TransportTestsConfiguration(); diff --git a/src/ServiceControlInstaller.Engine.UnitTests/Configuration/InstallationFixture.cs b/src/ServiceControlInstaller.Engine.UnitTests/Configuration/InstallationFixture.cs index 1ca584aaab..cef45fd971 100644 --- a/src/ServiceControlInstaller.Engine.UnitTests/Configuration/InstallationFixture.cs +++ b/src/ServiceControlInstaller.Engine.UnitTests/Configuration/InstallationFixture.cs @@ -3,7 +3,7 @@ using System.IO; using NUnit.Framework; - public class InstallationFixture + public abstract class InstallationFixture { [SetUp] public void SetUp()