Force updater to only update runtime files if there is only 1 PoB instance#1516
Open
LocalIdentity wants to merge 6 commits intodevfrom
Open
Force updater to only update runtime files if there is only 1 PoB instance#1516LocalIdentity wants to merge 6 commits intodevfrom
LocalIdentity wants to merge 6 commits intodevfrom
Conversation
added 3 commits
October 24, 2025 17:37
Adds a safeguard when updating runtime files that all other instances of PoB are closed so that the updater doesn't run into issues For linux systems it instead shows a popup as we can't reliably detect the instance count
mode == "basic" already means we are touching runtime files so no need for extra work
Wires77
reviewed
Oct 28, 2025
src/HeadlessWrapper.lua
Outdated
Comment on lines
155
to
157
| function GetProcessCount(names) | ||
| return 1 | ||
| end |
Wires77
reviewed
Oct 28, 2025
| @@ -19,8 +19,7 @@ local updateProcessCandidates = { | |||
| -- Returns the total number of running processes that match any known PoB executable names. | |||
| local function getMatchingProcessCount() | |||
| if not isWindows then | |||
Member
There was a problem hiding this comment.
Instead of using isWindows anywhere, just call the function and return the error. You could make the error say something platform related on the C++ side.
Wires77
reviewed
Oct 28, 2025
Member
There was a problem hiding this comment.
This works well, though the white error box is a bit jarring. Maybe we can use updateErrMsg instead, like this:
The only concern with this approach would be that the message gets missed or ignored.
Code for this if you want to use it:
local prompt = string.format("%d other Path of Building %s %s open.\nClose other copies before applying this update,\nthen press Update again.", otherCount, instanceLabel, verb)
--self:ShowPrompt(1, 0.5, 0, prompt)
self.updateErrMsg = promptWe'd have to mess with the Update button behavior and title text too to make it perfect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When PoB updates its runtime files it will fail to update if you have more than 1 instance of PoB open. This PR adds a check for if you have more than 1 instance open and will not let you update until you've closed them
Steps taken to verify a working solution:
After screenshot: