My fucking god... ESP32 wireless is tick-precise. Also fix dpad incorrectly sticking.

Author: Mysticial

SerialPrograms/Source/Controllers/SerialPABotBase/SerialPABotBase.cpp

@@ -77,13 +77,16 @@ const std::map<
         }},
         {PABB_PID_PABOTBASE_ESP32, {
             {ControllerType::NintendoSwitch_WirelessProController, {
+                ControllerFeature::TickPrecise,
                 ControllerFeature::QueryCommandQueueSize,
                 ControllerFeature::NintendoSwitch_ProController,
             }},
             {ControllerType::NintendoSwitch_LeftJoycon, {
+                ControllerFeature::TickPrecise,
                 ControllerFeature::QueryCommandQueueSize,
             }},
             {ControllerType::NintendoSwitch_RightJoycon, {
+                ControllerFeature::TickPrecise,
                 ControllerFeature::QueryCommandQueueSize,
             }},
         }},

SerialPrograms/Source/NintendoSwitch/Commands/NintendoSwitch_Commands_PushButtons.cpp

@@ -6,6 +6,7 @@
 
 #include <sstream>
 #include "ClientSource/Libraries/MessageConverter.h"
+#include "CommonFramework/GlobalSettingsPanel.h"
 #include "NintendoSwitch/NintendoSwitch_Settings.h"
 #include "NintendoSwitch_Commands_PushButtons.h"
 #include "NintendoSwitch_Commands_Superscalar.h"
@@ -155,6 +156,10 @@ int register_message_converters_push_button_framework(){
     register_message_converter(
         PABB_MSG_CONTROLLER_STATE,
         [](const std::string& body){
+            //  Disable this by default since it's very spammy.
+            if (!GlobalSettings::instance().LOG_EVERYTHING){
+                return std::string();
+            }
             std::ostringstream ss;
             ss << "controller_state() - ";
             if (body.size() != sizeof(pabb_controller_state)){ ss << "(invalid size)" << std::endl; return ss.str(); }

SerialPrograms/Source/NintendoSwitch/Controllers/SerialPABotBase/NintendoSwitch_PokkenController.cpp

@@ -171,6 +171,8 @@ void SerialPABotBase_PokkenController::status_thread(){
             error = e.message();
         }catch (ConnectionException& e){
             error = e.message();
+        }catch (...){
+            error = "Unknown error.";
         }
         if (!error.empty()){
             m_handle.set_status_line1(error, COLOR_RED);

SerialPrograms/Source/NintendoSwitch/Controllers/SerialPABotBase/NintendoSwitch_WirelessProController.cpp

@@ -34,7 +34,7 @@ SerialPABotBase_WirelessProController::SerialPABotBase_WirelessProController(
     : SerialPABotBase_ProController(
         logger,
         ControllerType::NintendoSwitch_WirelessProController,
-        14ms,
+        0ms,
         connection,
         requirements
     )
@@ -105,6 +105,10 @@ int register_message_converters_ESP32(){
     register_message_converter(
         PABB_MSG_ESP32_REPORT,
         [](const std::string& body){
+            //  Disable this by default since it's very spammy.
+            if (!GlobalSettings::instance().LOG_EVERYTHING){
+                return std::string();
+            }
             std::ostringstream ss;
             ss << "ESP32_controller_state() - ";
             if (body.size() != sizeof(pabb_esp32_report30)){ ss << "(invalid size)" << std::endl; return ss.str(); }
@@ -164,11 +168,13 @@ void SerialPABotBase_WirelessProController::push_state(const Cancellable* cancel
     //  7 = Charging Grip
 
     //  Left
-    SplitDpad dpad = convert_unified_to_split_dpad(m_dpad.position);
-    report.button5 |= (dpad.down  ? 1 : 0) << 0;
-    report.button5 |= (dpad.up    ? 1 : 0) << 1;
-    report.button5 |= (dpad.right ? 1 : 0) << 2;
-    report.button5 |= (dpad.left  ? 1 : 0) << 3;
+    if (m_dpad.is_busy()){
+        SplitDpad dpad = convert_unified_to_split_dpad(m_dpad.position);
+        report.button5 |= (dpad.down  ? 1 : 0) << 0;
+        report.button5 |= (dpad.up    ? 1 : 0) << 1;
+        report.button5 |= (dpad.right ? 1 : 0) << 2;
+        report.button5 |= (dpad.left  ? 1 : 0) << 3;
+    }
     //  4 = Left Joycon: SR
     //  5 = Left Joycon: SL
     report.button5 |= (m_buttons[4].is_busy() ? 1 : 0) << 6;    //  L
@@ -265,18 +271,22 @@ void SerialPABotBase_WirelessProController::status_thread(){
                 ? html_color_text("Yes", theme_friendly_darkblue())
                 : html_color_text("No", COLOR_RED)
             );
-            str += ", Paired: " + (status_paired
+            str += " - Paired: " + (status_paired
                 ? html_color_text("Yes", theme_friendly_darkblue())
                 : html_color_text("No", COLOR_RED)
             );
 
             m_handle.set_status_line1(str);
+        }catch (OperationCancelledException&){
+            break;
         }catch (InvalidConnectionStateException&){
             break;
         }catch (SerialProtocolException& e){
             error = e.message();
         }catch (ConnectionException& e){
             error = e.message();
+        }catch (...){
+            error = "Unknown error.";
         }
         if (!error.empty()){
             m_handle.set_status_line1(error, COLOR_RED);