Fix lifetime sanitizer false alarm.

Author: Mysticial

Common/Cpp/Concurrency/AsyncTask.cpp

@@ -38,25 +38,29 @@ AsyncTask::~AsyncTask(){
 
 
 void AsyncTask::report_cancelled() noexcept{
+    {
 #ifdef PA_SANITIZE_AsyncTask
-    auto scope = m_sanitizer.check_scope();
+        auto scope = m_sanitizer.check_scope();
 #endif
-    m_state.store(State::FINISHED, std::memory_order_release);
-    {
-        std::lock_guard<std::mutex> lg(m_lock);
+        m_state.store(State::FINISHED, std::memory_order_release);
+        {
+            std::lock_guard<std::mutex> lg(m_lock);
+        }
+        m_cv.notify_all();
     }
-    m_cv.notify_all();
     m_state.store(State::SAFE_TO_DESTRUCT, std::memory_order_release);
 }
 void AsyncTask::run() noexcept{
+    {
 #ifdef PA_SANITIZE_AsyncTask
-    auto scope = m_sanitizer.check_scope();
+        auto scope = m_sanitizer.check_scope();
 #endif
-    try{
-        m_task();
-    }catch (...){
-        std::lock_guard<std::mutex> lg(m_lock);
-        m_exception = std::current_exception();
+        try{
+            m_task();
+        }catch (...){
+            std::lock_guard<std::mutex> lg(m_lock);
+            m_exception = std::current_exception();
+        }
     }
     report_cancelled();
 }