Fix logger

Author: pifopi

ClientSource/Connection/MessageLogger.cpp

@@ -96,11 +96,6 @@ void SerialLogger::log(const std::string& msg, Color color){
         m_logger.log(msg, color);
     }
 }
-void SerialLogger::log(std::string msg){
-    if (ok_to_log()){
-        m_logger.log(msg, COLOR_DARKGREEN);
-    }
-}
 
 bool SerialLogger::ok_to_log(){
     WallClock now = current_time();

ClientSource/Connection/MessageLogger.h

@@ -40,13 +40,12 @@ class MessageLogger : public MessageSniffer{
 
 
 
-class SerialLogger : public Logger, public MessageLogger{
+class SerialLogger : public MessageLogger{
 public:
     SerialLogger(Logger& logger, bool log_everything);
 
     virtual void log(const char* msg, Color color = Color()) override;
     virtual void log(const std::string& msg, Color color = Color()) override;
-    virtual void log(std::string msg) override;
 
 private:
     bool ok_to_log();

ClientSource/Connection/MessageSniffer.h

@@ -15,9 +15,8 @@ namespace PokemonAutomation{
 struct BotBaseMessage;
 
 
-class MessageSniffer{
+class MessageSniffer : public Logger{
 public:
-    virtual void log(std::string msg){}
     virtual void on_send(const BotBaseMessage& message, bool is_retransmit){}
     virtual void on_recv(const BotBaseMessage& message){}
 };

Common/Cpp/AbstractLogger.h

@@ -16,7 +16,7 @@ namespace PokemonAutomation{
 
 class Logger{
 public:
-    virtual void log(const std::string& msg, Color color = Color()) = 0;
+    virtual void log([[maybe_unused]] const std::string& msg, [[maybe_unused]] Color color = Color()){};
     virtual void log(std::string&& msg, Color color = Color()){
         log((const std::string&)msg, color);
     }