Fix deadlock due to missed error notification.

Mysticial · Mysticial · commit 20e3a13db578 · 2025-07-10T10:06:53.000-07:00
diff --git a/ClientSource/Connection/PABotBase.cpp b/ClientSource/Connection/PABotBase.cpp
@@ -157,6 +157,10 @@ void PABotBase::wait_for_all_requests(const Cancellable* cancelled){
             ReadSpinLock lg0(m_state_lock);
             throw InvalidConnectionStateException(m_error_message);
         }
+        if (m_error.load(std::memory_order_acquire)){
+            ReadSpinLock lg0(m_state_lock);
+            throw ConnectionException(&m_logger, m_error_message);
+        }
         {
             ReadSpinLock lg1(m_state_lock, "PABotBase::wait_for_all_requests()");
 #if 0

Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,10 @@ void PABotBase::wait_for_all_requests(const Cancellable* cancelled){`
`157`	`157`	`ReadSpinLock lg0(m_state_lock);`
`158`	`158`	`throw InvalidConnectionStateException(m_error_message);`
`159`	`159`	`}`
	`160`	`+ if (m_error.load(std::memory_order_acquire)){`
	`161`	`+ ReadSpinLock lg0(m_state_lock);`
	`162`	`+ throw ConnectionException(&m_logger, m_error_message);`
	`163`	`+ }`
`160`	`164`	`{`
`161`	`165`	`ReadSpinLock lg1(m_state_lock, "PABotBase::wait_for_all_requests()");`
`162`	`166`	`#if 0`