Fix build. Add tooltips.

Author: Mysticial

Common/Cpp/ExpressionEvaluator.cpp

@@ -4,6 +4,7 @@
  *
  */
 
+#include <limits>
 #include <string>
 #include <map>
 #include <vector>

Common/Cpp/ExpressionEvaluator.h

@@ -16,6 +16,7 @@ int64_t parse_expression(
     const std::map<std::string, int64_t>& variables,
     const std::string& expression
 );
+
 uint32_t parse_ticks_ui32(const std::string& expression);
 int32_t parse_ticks_i32(const std::string& expression);
 

Common/Cpp/Options/TimeDurationOption.h

@@ -102,14 +102,14 @@ class MillisecondsCell : public TimeDurationCell<std::chrono::milliseconds>{
 public:
     template <class... Args>
     MillisecondsCell(Args&&... args)
-        : TimeDurationCell<std::chrono::milliseconds>("ms", std::forward<Args>(args)...)
+        : TimeDurationCell<std::chrono::milliseconds>("milliseconds", std::forward<Args>(args)...)
     {}
 };
 class MillisecondsOption : public TimeDurationOption<std::chrono::milliseconds>{
 public:
     template <class... Args>
     MillisecondsOption(std::string label, Args&&... args)
-        : TimeDurationOption<std::chrono::milliseconds>(std::move(label), "ms", std::forward<Args>(args)...)
+        : TimeDurationOption<std::chrono::milliseconds>(std::move(label), "milliseconds", std::forward<Args>(args)...)
     {}
 };
 

Common/Qt/Options/TimeDurationWidget.cpp

@@ -27,6 +27,17 @@ TimeDurationCellWidget<Type>::TimeDurationCellWidget(QWidget& parent, TimeDurati
     , ConfigWidget(value, *this)
     , m_value(value)
 {
+    this->setToolTip(QString::fromStdString(
+        "Time duration in " + value.units() +
+        "<br><br>"
+        "For controller timings, this will be rounded "
+        "up to the tick size of the controller."
+        "<br><br>"
+        "The tick size for wired controllers is usually 8ms and are very precise."
+        "<br><br>"
+        "Wireless controllers have larger tick sizes and are imprecise due to wireless communication latency."
+    ));
+
     connect(
         this, &QLineEdit::textChanged,
         this, [this](const QString& text){
@@ -61,6 +72,17 @@ TimeDurationOptionWidget<Type>::TimeDurationOptionWidget(QWidget& parent, TimeDu
     , ConfigWidget(value, *this)
     , m_value(value)
 {
+    this->setToolTip(QString::fromStdString(
+        "Time duration in " + value.units() +
+        "<br><br>"
+        "For controller timings, this will be rounded "
+        "up to the tick size of the controller."
+        "<br><br>"
+        "The tick size for wired controllers is usually 8ms and are very precise."
+        "<br><br>"
+        "Wireless controllers have larger tick sizes and are imprecise due to wireless communication latency."
+    ));
+
     QHBoxLayout* layout = new QHBoxLayout(this);
     layout->setContentsMargins(0, 0, 0, 0);
     QLabel* text = new QLabel(QString::fromStdString(m_value.label()), this);