Don't declare ready until after configuring. Add a way to query for tick precision.

Author: Mysticial

SerialPrograms/Source/NintendoSwitch/Controllers/NintendoSwitch_ProController.cpp

@@ -103,8 +103,9 @@ class ProController::KeyboardManager : public KeyboardInputController{
 ProController::~ProController(){
 
 }
-ProController::ProController()
-    : m_keyboard_manager(CONSTRUCT_TOKEN, *this)
+ProController::ProController(Milliseconds timing_variation)
+    : m_timing_variation(timing_variation)
+    , m_keyboard_manager(CONSTRUCT_TOKEN, *this)
 {
 
 }

SerialPrograms/Source/NintendoSwitch/Controllers/NintendoSwitch_ProController.h

@@ -78,10 +78,14 @@ class ProController : public AbstractController{
     using ContextType = ProControllerContext;
 
     virtual ~ProController();
-    ProController();
+    ProController(Milliseconds timing_variation);
 
     virtual Logger& logger() = 0;
 
+    Milliseconds timing_variation() const{
+        return m_timing_variation;
+    }
+
 
 public:
     //  General Control
@@ -294,6 +298,8 @@ class ProController : public AbstractController{
 
 
 private:
+    const Milliseconds m_timing_variation;
+
     class KeyboardManager;
     Pimpl<KeyboardManager> m_keyboard_manager;
 };

SerialPrograms/Source/NintendoSwitch/Controllers/NintendoSwitch_ProControllerWithScheduler.cpp

@@ -17,8 +17,9 @@ using namespace std::chrono_literals;
 
 
 
-ProControllerWithScheduler::ProControllerWithScheduler(Logger& logger)
-    : SuperscalarScheduler(
+ProControllerWithScheduler::ProControllerWithScheduler(Logger& logger, Milliseconds timing_variation)
+    : ProController(timing_variation)
+    , SuperscalarScheduler(
         logger, Milliseconds(4),
         {
             &m_buttons[ 0],

SerialPrograms/Source/NintendoSwitch/Controllers/NintendoSwitch_ProControllerWithScheduler.h

@@ -47,7 +47,7 @@ class ProControllerWithScheduler :
     protected SuperscalarScheduler
 {
 public:
-    ProControllerWithScheduler(Logger& logger);
+    ProControllerWithScheduler(Logger& logger, Milliseconds timing_variation);
 
     virtual Logger& logger() override{
         return m_logger;

SerialPrograms/Source/NintendoSwitch/Controllers/NintendoSwitch_ProController_SerialPABotBase.cpp

@@ -35,7 +35,7 @@ ProController_SerialPABotBase::ProController_SerialPABotBase(
     SerialPABotBase::SerialPABotBase_Connection& connection,
     const ControllerRequirements& requirements
 )
-    : ProControllerWithScheduler(logger)
+    : ProControllerWithScheduler(logger, 0ms)
     , m_handle(connection)
     , m_serial(connection.botbase())
 {

SerialPrograms/Source/NintendoSwitch/Controllers/SysbotBase/SysbotBase_Connection.cpp

@@ -174,11 +174,11 @@ void SysbotBaseNetwork_Connection::thread_body_internal(){
     m_logger.log(message + " (Success)", COLOR_BLUE);
     set_status(html_color_text("Connected!", COLOR_BLUE));
 
-    declare_ready(supported_controllers());
-
     m_socket->write("configure mainLoopSleepTime 0\n");
     m_socket->flush();
 
+    declare_ready(supported_controllers());
+
     //
     //  This is stupid. Since we cannot block the constructor of this class to
     //  wait for the connection, we spawn this thread to do the connection.

SerialPrograms/Source/NintendoSwitch/Controllers/SysbotBase/SysbotBase_ProController.cpp

@@ -26,7 +26,7 @@ ProController_SysbotBase::ProController_SysbotBase(
     SysbotBase::SysbotBaseNetwork_Connection& connection,
     const ControllerRequirements& requirements
 )
-    : ProControllerWithScheduler(logger)
+    : ProControllerWithScheduler(logger, std::chrono::milliseconds(40))
     , m_connection(connection)
     , m_stopping(false)
     , m_replace_on_next(false)