Remove unnecessary atomic.

Author: Mysticial

SerialPrograms/Source/Controllers/Schedulers/SuperscalarScheduler.cpp

@@ -37,7 +37,7 @@ void SuperscalarScheduler::clear() noexcept{
     m_max_free_time = now;
     m_state_changes.clear();
     m_live_commands.clear();
-    m_pending_clear.store(false, std::memory_order_release);
+    m_pending_clear = false;
 }
 
 SuperscalarScheduler::State SuperscalarScheduler::current_live_commands(){
@@ -163,7 +163,7 @@ void SuperscalarScheduler::process_schedule(Schedule& schedule){
 }
 
 void SuperscalarScheduler::issue_wait_for_all(Schedule& schedule){
-    if (m_pending_clear.load(std::memory_order_acquire)){
+    if (m_pending_clear){
         clear();
         return;
     }
@@ -181,7 +181,7 @@ void SuperscalarScheduler::issue_nop(Schedule& schedule, WallDuration delay){
     if (delay <= WallDuration::zero()){
         return;
     }
-    if (m_pending_clear.load(std::memory_order_acquire)){
+    if (m_pending_clear){
         clear();
     }
 //    cout << "issue_nop(): " << m_state_changes.size() << endl;
@@ -197,7 +197,7 @@ void SuperscalarScheduler::issue_nop(Schedule& schedule, WallDuration delay){
     process_schedule(schedule);
 }
 void SuperscalarScheduler::issue_wait_for_resource(Schedule& schedule, size_t resource_id){
-    if (m_pending_clear.load(std::memory_order_acquire)){
+    if (m_pending_clear){
         clear();
         return;
     }
@@ -221,7 +221,7 @@ void SuperscalarScheduler::issue_to_resource(
     std::shared_ptr<const SchedulerResource> resource,
     WallDuration delay, WallDuration hold, WallDuration cooldown
 ){
-    if (m_pending_clear.load(std::memory_order_acquire)){
+    if (m_pending_clear){
         clear();
     }
 

SerialPrograms/Source/Controllers/Schedulers/SuperscalarScheduler.h

@@ -10,7 +10,6 @@
 #include <memory>
 #include <set>
 #include <map>
-#include <atomic>
 #include "Common/Compiler.h"
 #include "Common/Cpp/Time.h"
 #include "Common/Cpp/AbstractLogger.h"
@@ -50,13 +49,8 @@ class SuperscalarScheduler{
 public:
     SuperscalarScheduler(Logger& logger, WallDuration flush_threshold);
 
-
-public:
-    //  This is intended to be run on a different thread from the functions in
-    //  the next section. So it is safe to run from anywhere.
-
     void clear_on_next(){
-        m_pending_clear.store(true, std::memory_order_release);
+        m_pending_clear = true;
     }
 
 
@@ -111,7 +105,7 @@ class SuperscalarScheduler{
     //  much time.
     const WallDuration m_flush_threshold;
 
-    std::atomic<bool> m_pending_clear;
+    bool m_pending_clear;
 
     //  The construction time of this object. This is only used for debugging
     //  purposes since it lets you print wall times relative to this.

SerialPrograms/Source/Controllers/StandardHid/StandardHid_Keyboard.h

@@ -47,6 +47,10 @@ class Keyboard : public AbstractController{
 public:
     //  Standard Commands
 
+    //  Note that only 6 keys (not counting modifiers) can be communicated at
+    //  once over the HID protocol. If you hold down more than 6, only the first
+    //  6 chronologically will be applied.
+
     virtual void issue_key(
         const Cancellable* cancellable,
         Milliseconds delay, Milliseconds hold, Milliseconds cooldown,