Everyone uses the same start game mash duration since it's not game-specific.

Author: Mysticial

SerialPrograms/Source/NintendoSwitch/NintendoSwitch_Settings.cpp

@@ -75,6 +75,11 @@ ConsoleSettings::ConsoleSettings()
         LockMode::LOCK_WHILE_RUNNING,
         false
     )
+    , START_GAME_MASH(
+        "<b>1. Start Game Mash:</b><br>Mash A for this long to start the game.",
+        LockMode::LOCK_WHILE_RUNNING,
+        "2000 ms"
+    )
     , SETTINGS_TO_HOME_DELAY0(
         "<b>Settings to Home Delay:</b><br>Delay from pressing home anywhere in the settings to return to the home menu.",
         LockMode::LOCK_WHILE_RUNNING,
@@ -137,6 +142,7 @@ ConsoleSettings::ConsoleSettings()
 {
     PA_ADD_OPTION(CONTROLLER_SETTINGS);
     PA_ADD_OPTION(TRUST_USER_CONSOLE_SELECTION);
+    PA_ADD_OPTION(START_GAME_MASH);
     PA_ADD_OPTION(SETTINGS_TO_HOME_DELAY0);
     PA_ADD_OPTION(START_GAME_REQUIRES_INTERNET);
     PA_ADD_OPTION(START_GAME_INTERNET_CHECK_DELAY0);

SerialPrograms/Source/NintendoSwitch/NintendoSwitch_Settings.h

@@ -43,6 +43,7 @@ class ConsoleSettings : public BatchOption{
     ControllerSettingsTable CONTROLLER_SETTINGS;
 
     BooleanCheckBoxOption TRUST_USER_CONSOLE_SELECTION;
+    MillisecondsOption START_GAME_MASH;
     MillisecondsOption SETTINGS_TO_HOME_DELAY0;
     BooleanCheckBoxOption START_GAME_REQUIRES_INTERNET;
     MillisecondsOption START_GAME_INTERNET_CHECK_DELAY0;

SerialPrograms/Source/PokemonBDSP/PokemonBDSP_Settings.cpp

@@ -38,11 +38,6 @@ GameSettings::GameSettings()
         "1000 ms"
     )
     , m_start_game_timings("<font size=4><b>Start Game Timings:</b></font>")
-    , START_GAME_MASH0(
-        "<b>1. Start Game Mash:</b><br>Mash A for this long to start the game.",
-        LockMode::LOCK_WHILE_RUNNING,
-        "2000 ms"
-    )
     , START_GAME_WAIT0(
         "<b>2. Start Game Wait:</b><br>Wait this long for the game to load.",
         LockMode::LOCK_WHILE_RUNNING,
@@ -145,7 +140,6 @@ GameSettings::GameSettings()
     PA_ADD_OPTION(GAME_TO_HOME_DELAY0);
 
     PA_ADD_STATIC(m_start_game_timings);
-    PA_ADD_OPTION(START_GAME_MASH0);
     PA_ADD_OPTION(START_GAME_WAIT0);
     PA_ADD_OPTION(ENTER_GAME_MASH0);
     PA_ADD_OPTION(ENTER_GAME_WAIT0);

SerialPrograms/Source/PokemonBDSP/PokemonBDSP_Settings.h

@@ -28,7 +28,6 @@ class GameSettings : public BatchOption{
     MillisecondsOption GAME_TO_HOME_DELAY0;
 
     SectionDividerOption m_start_game_timings;
-    MillisecondsOption START_GAME_MASH0;
     MillisecondsOption START_GAME_WAIT0;
     MillisecondsOption ENTER_GAME_MASH0;
     MillisecondsOption ENTER_GAME_WAIT0;

SerialPrograms/Source/PokemonBDSP/Programs/PokemonBDSP_GameEntry.cpp

@@ -85,11 +85,11 @@ bool reset_game_from_home(
             context,
             tolerate_update_menu,
             0, 0,
-            GameSettings::instance().START_GAME_MASH0
+            ConsoleSettings::instance().START_GAME_MASH
         );
     }else{
         pbf_press_button(context, BUTTON_X, 50, 0);
-        pbf_mash_button(context, BUTTON_A, GameSettings::instance().START_GAME_MASH0);
+        pbf_mash_button(context, BUTTON_A, ConsoleSettings::instance().START_GAME_MASH);
     }
     bool ret = openedgame_to_ingame(
         env, console, context,

SerialPrograms/Source/PokemonLA/PokemonLA_Settings.cpp

@@ -39,11 +39,6 @@ GameSettings::GameSettings()
         "30 s"
     )
     , m_start_game_timings("<font size=4><b>Start Game Timings:</b></font>")
-    , START_GAME_MASH0(
-        "<b>1. Start Game Mash:</b><br>Mash A for this long to start the game.",
-        LockMode::LOCK_WHILE_RUNNING,
-        "2000 ms"
-    )
     , START_GAME_WAIT1(
         "<b>2. Start Game Wait:</b><br>Wait this long for the game to load.",
         LockMode::LOCK_WHILE_RUNNING,
@@ -101,7 +96,6 @@ GameSettings::GameSettings()
     PA_ADD_OPTION(LOAD_REGION_TIMEOUT0);
 
     PA_ADD_STATIC(m_start_game_timings);
-    PA_ADD_OPTION(START_GAME_MASH0);
     PA_ADD_OPTION(START_GAME_WAIT1);
     PA_ADD_OPTION(ENTER_GAME_MASH0);
     PA_ADD_OPTION(ENTER_GAME_WAIT0);

SerialPrograms/Source/PokemonLA/PokemonLA_Settings.h

@@ -30,7 +30,6 @@ class GameSettings : public BatchOption{
     MillisecondsOption LOAD_REGION_TIMEOUT0;
 
     SectionDividerOption m_start_game_timings;
-    MillisecondsOption START_GAME_MASH0;
     MillisecondsOption START_GAME_WAIT1;
     MillisecondsOption ENTER_GAME_MASH0;
     MillisecondsOption ENTER_GAME_WAIT0;

SerialPrograms/Source/PokemonLA/Programs/PokemonLA_GameEntry.cpp

@@ -40,11 +40,11 @@ bool reset_game_to_gamemenu(
             context,
             tolerate_update_menu,
             0, 0,
-            GameSettings::instance().START_GAME_MASH0
+            ConsoleSettings::instance().START_GAME_MASH
         );
     }else{
         pbf_press_button(context, BUTTON_X, 50, 0);
-        pbf_mash_button(context, BUTTON_A, GameSettings::instance().START_GAME_MASH0);
+        pbf_mash_button(context, BUTTON_A, ConsoleSettings::instance().START_GAME_MASH);
     }
 
     // Now the game has opened:

SerialPrograms/Source/PokemonLA/Programs/PokemonLA_GameEntry.h

@@ -19,22 +19,24 @@ namespace PokemonLA{
 
 
 
-// From Switch Home menu, reset game and wait until the game menu screen (where
-// "Press A" is displayed to enter the game) is shown.
+//  From Switch Home menu, reset game and wait until the game menu screen (where
+//  "Press A" is displayed to enter the game) is shown.
 bool reset_game_to_gamemenu(
     ConsoleHandle& console, ProControllerContext& context,
     bool tolerate_update_menu
 );
 
-// From the game menu screen (where "Press A" is displayed to enter the game),
-// mash A to enter the game and wait until the black screen is gone.
+//  From the game menu screen (where "Press A" is displayed to enter the game),
+//  mash A to enter the game and wait until the black screen is gone.
 bool gamemenu_to_ingame(
     VideoStream& stream, ProControllerContext& context,
     Milliseconds mash_duration, Milliseconds enter_game_timeout
 );
 
-// From Switch Home menu, start game and wait until the player character appears in game.
-// post_wait_time: how many ticks to wait after the black screen (shown when loading the map) is over.
+//  From Switch Home menu, start game and wait until the player character
+//  appears in game.
+//  post_wait_time: how many ticks to wait after the black screen
+//  (shown when loading the map) is over.
 bool reset_game_from_home(
     ProgramEnvironment& env,
     ConsoleHandle& console, ProControllerContext& context,

SerialPrograms/Source/PokemonLGPE/PokemonLGPE_Settings.cpp

@@ -28,11 +28,6 @@ GameSettings::GameSettings()
         "1000 ms"
     )
     , m_start_game_timings("<font size=4><b>Start Game Timings:</b></font>")
-    , START_GAME_MASH0(
-        "<b>1. Start Game Mash:</b><br>Mash A for this long to start the game.",
-        LockMode::LOCK_WHILE_RUNNING,
-        "2000 ms"
-    )
     , START_GAME_WAIT1(
         "<b>2. Start Game Wait:</b><br>Wait this long for the game to load.",
         LockMode::LOCK_WHILE_RUNNING,
@@ -66,7 +61,6 @@ GameSettings::GameSettings()
     PA_ADD_OPTION(GAME_TO_HOME_DELAY0);
 
     PA_ADD_STATIC(m_start_game_timings);
-    PA_ADD_OPTION(START_GAME_MASH0);
     PA_ADD_OPTION(START_GAME_WAIT1);
     PA_ADD_OPTION(ENTER_GAME_MASH0);
     PA_ADD_OPTION(ENTER_GAME_WAIT0);