Migrate AutoStory off old controller state joystick API.

Author: Mysticial

SerialPrograms/Source/NintendoSwitch/Commands/NintendoSwitch_Commands_PushButtons.h

@@ -98,6 +98,7 @@ void grip_menu_connect_go_home  (ProControllerContext& context);
 //  button overlapping, you should use ssf_* directly. (though lots of existing
 //  programs already use this for overlapping)
 //
+#if 0
 void pbf_controller_state(
     ProControllerContext& context,
     Button button,
@@ -106,6 +107,7 @@ void pbf_controller_state(
     uint8_t right_x, uint8_t right_y,
     uint16_t ticks
 );
+#endif
 void pbf_controller_state(
     ProControllerContext& context,
     Button button,

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_10.cpp

@@ -118,7 +118,7 @@ void checkpoint_21(
         realign_player(env.program_info(), env.console, context, PlayerRealignMode::REALIGN_NEW_MARKER, 128, 0, 50);
         pbf_move_left_joystick(context, 128, 0, 200, 100);
         // run and jump over wall
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 100);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 800ms);
 
         BlackScreenOverWatcher black_screen(COLOR_RED, { 0.2, 0.2, 0.6, 0.6 });
         int ret = wait_until(

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_16.cpp

@@ -108,7 +108,7 @@ void checkpoint_35(
         // walk towards elevator
         pbf_move_left_joystick(context, 128, 0, 700, 100);
         // jump to ensure you get on elevator
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 200);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1600ms);
         pbf_wait(context, 3 * TICKS_PER_SECOND);
         // wait for overworld to reappear after stepping off elevator
         wait_for_overworld(env.program_info(), env.console, context, 30);

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_17.cpp

@@ -153,7 +153,7 @@ void checkpoint_38(
         // walk towards elevator
         pbf_move_left_joystick(context, 128, 0, 700, 100);
         // jump to ensure you get on elevator
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 200);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1600ms);
         pbf_wait(context, 3 * TICKS_PER_SECOND);
         // wait for overworld to reappear after stepping off elevator
         wait_for_overworld(env.program_info(), env.console, context, 30);

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_18.cpp

@@ -265,7 +265,7 @@ void checkpoint_40(
 
         // jump over the fence to exit Mesagoza
         pbf_move_left_joystick(context, 128, 0, 200, 50);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 200);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1600ms);
 
         wait_for_overworld(env.program_info(), env.console, context);
 

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_20.cpp

@@ -361,7 +361,7 @@ void checkpoint_44(
 
         // align to corner 7.5. bush
         direction.change_direction(env.program_info(), env.console, context, 3.11);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 150);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1200ms);
         pbf_move_left_joystick(context, 128, 0, 60, 100);
         direction.change_direction(env.program_info(), env.console, context, 4.28);
         pbf_move_left_joystick(context, 128, 0, 200, 100);
@@ -385,7 +385,7 @@ void checkpoint_44(
         // align to corner 8.1. bush
         direction.change_direction(env.program_info(), env.console, context, 4.54);
         pbf_move_left_joystick(context, 128, 0, 200, 100);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 150);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1200ms);
         pbf_move_left_joystick(context, 128, 0, 200, 100);
         direction.change_direction(env.program_info(), env.console, context, 3.60);
         pbf_move_left_joystick(context, 128, 0, 400, 100);
@@ -416,7 +416,7 @@ void checkpoint_44(
         pbf_move_left_joystick(context, 128, 255, 200, 100);
         direction.change_direction(env.program_info(), env.console, context, 4.89);
         pbf_move_left_joystick(context, 128, 0, 350, 100);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 180);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1440ms);
         get_off_ride(env.program_info(), env.console, context);
         direction.change_direction(env.program_info(), env.console, context, 3.60);
         pbf_move_left_joystick(context, 128, 0, 600, 100);
@@ -463,7 +463,7 @@ void checkpoint_44(
         // align to corner 11.1. bush
         direction.change_direction(env.program_info(), env.console, context, 0.65);
         pbf_move_left_joystick(context, 128, 0, 200, 100);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 150);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1200ms);
         pbf_move_left_joystick(context, 128, 0, 800, 100);
 
         direction.change_direction(env.program_info(), env.console, context, 4.49);
@@ -515,7 +515,7 @@ void checkpoint_45(
         pbf_move_left_joystick(context, 128, 0, 400, 100);
 
         direction.change_direction(env.program_info(), env.console, context, 2.18);
-        pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 150);
+        pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 1200ms);
         pbf_move_left_joystick(context, 128, 0, 400, 100);
         direction.change_direction(env.program_info(), env.console, context, 3.16);
         pbf_move_left_joystick(context, 0, 0, 100, 50);

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_22.cpp

@@ -171,7 +171,7 @@ void checkpoint_50(
             [&](const ProgramInfo& info, VideoStream& stream, ProControllerContext& context){
                 // jump over the fence when stationary
                 context.wait_for_all_requests();
-                pbf_controller_state(context, BUTTON_B, DPAD_NONE, 128, 0, 128, 128, 100);
+                pbf_controller_state(context, BUTTON_B, DPAD_NONE, {0, +1}, {0, 0}, 800ms);
                 realign_player(env.program_info(), env.console, context, PlayerRealignMode::REALIGN_OLD_MARKER);
             }
         );          

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory_Segment_24.cpp

@@ -129,7 +129,7 @@ void checkpoint_55(
             direction.change_direction(env.program_info(), env.console, context, 2.565);
             // run at Orthworm. run into its second position as well.
             pbf_move_left_joystick(context, 128, 0, 50, 0);
-            pbf_controller_state(context, BUTTON_LCLICK, DPAD_NONE, 128, 0, 128, 128, 500);
+            pbf_controller_state(context, BUTTON_LCLICK, DPAD_NONE, {0, +1}, {0, 0}, 4000ms);
             pbf_move_left_joystick(context, 255, 0, 300, 500);
 
             get_off_ride(env.program_info(), env.console, context);