Add clang on the CI for windows and linux

Author: pifopi

.github/workflows/cpp-ci-serial-programs.yml

@@ -10,11 +10,25 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows-2025, macos-13, ubuntu-24.04]
+        compiler: ['default', 'clang']
         qt_version: ['6.9.0']
         include:
-        - qt_version: '6.9.0'
-          qt_version_major: '6'
-          qt_modules: 'qtmultimedia qtserialport'
+          - qt_version: '6.9.0'
+            qt_version_major: '6'
+            qt_modules: 'qtmultimedia qtserialport'
+
+          - os: 'windows-2025'
+            compiler: 'clang'
+            cmake_additional_param: '-T ClangCL'
+
+          - os: 'ubuntu-24.04'
+            compiler: 'clang'
+            cmake_additional_param: '-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++'
+
+        exclude:
+          - os: 'macos-13'
+            compiler: 'clang'
+            # Excluded because macos default toolset is already clang
 
     steps:
     - uses: actions/checkout@v4
@@ -42,7 +56,7 @@ jobs:
         cd Arduino-Source/SerialPrograms
         mkdir bin
         cd bin
-        cmake .. -DQT_MAJOR:STRING=${{ matrix.qt_version_major }}
+        cmake .. -DQT_MAJOR:STRING=${{ matrix.qt_version_major }} ${{ matrix.cmake_additional_param }}
         cmake --build . --config Release --parallel 10
     - name: Copy resources
       if: startsWith(matrix.os, 'windows')

ClientSource/Connection/MessageLogger.cpp

@@ -96,11 +96,6 @@ void SerialLogger::log(const std::string& msg, Color color){
         m_logger.log(msg, color);
     }
 }
-void SerialLogger::log(std::string msg){
-    if (ok_to_log()){
-        m_logger.log(msg, COLOR_DARKGREEN);
-    }
-}
 
 bool SerialLogger::ok_to_log(){
     WallClock now = current_time();

ClientSource/Connection/MessageLogger.h

@@ -40,13 +40,12 @@ class MessageLogger : public MessageSniffer{
 
 
 
-class SerialLogger : public Logger, public MessageLogger{
+class SerialLogger : public MessageLogger{
 public:
     SerialLogger(Logger& logger, bool log_everything);
 
     virtual void log(const char* msg, Color color = Color()) override;
     virtual void log(const std::string& msg, Color color = Color()) override;
-    virtual void log(std::string msg) override;
 
 private:
     bool ok_to_log();

ClientSource/Connection/MessageSniffer.h

@@ -15,9 +15,8 @@ namespace PokemonAutomation{
 struct BotBaseMessage;
 
 
-class MessageSniffer{
+class MessageSniffer : public Logger{
 public:
-    virtual void log(std::string msg){}
     virtual void on_send(const BotBaseMessage& message, bool is_retransmit){}
     virtual void on_recv(const BotBaseMessage& message){}
 };

Common/Cpp/AbstractLogger.h

@@ -16,7 +16,7 @@ namespace PokemonAutomation{
 
 class Logger{
 public:
-    virtual void log(const std::string& msg, Color color = Color()) = 0;
+    virtual void log([[maybe_unused]] const std::string& msg, [[maybe_unused]] Color color = Color()){};
     virtual void log(std::string&& msg, Color color = Color()){
         log((const std::string&)msg, color);
     }