Autostory: fix change_settings_prior_to_autostory(). Fix ability to change ending segment while program runs.

Author: jw098

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory.cpp

@@ -187,7 +187,7 @@ AutoStory::AutoStory()
     , STARTPOINT_TUTORIAL(
         "<b>Start Point:</b><br>Program will start with this segment.",
         TUTORIAL_SEGMENTS_SELECT_DATABASE(),
-        LockMode::UNLOCK_WHILE_RUNNING,
+        LockMode::LOCK_WHILE_RUNNING,
         "0"
     )
     , ENDPOINT_TUTORIAL(
@@ -679,26 +679,39 @@ std::string AutoStory::end_segment_description(){
     return ALL_AUTO_STORY_SEGMENT_LIST()[segment_index]->end_text();
 }
 
+size_t AutoStory::get_start_segment_index(){
+    size_t start = 0;
 
-void AutoStory::run_autostory(SingleSwitchProgramEnvironment& env, ProControllerContext& context){
-    AutoStoryOptions options{
-        LANGUAGE,
-        STARTERCHOICE,
-        NOTIFICATION_STATUS_UPDATE
-    };    
+    if (STORY_SECTION == StorySection::TUTORIAL){
+        start = STARTPOINT_TUTORIAL.index();
+    }else if (STORY_SECTION == StorySection::MAIN_STORY){
+        start = (INDEX_OF_LAST_TUTORIAL_SEGMENT + 1) + STARTPOINT_MAINSTORY.index();
+    }
+    
+    return start;
+}
 
-    size_t start = STARTPOINT_TUTORIAL.index();
-    size_t end = ENDPOINT_TUTORIAL.index();
+size_t AutoStory::get_end_segment_index(){
+    size_t end = 0;
 
     if (STORY_SECTION == StorySection::TUTORIAL){
-        start = STARTPOINT_TUTORIAL.index();
         end = ENDPOINT_TUTORIAL.index();
     }else if (STORY_SECTION == StorySection::MAIN_STORY){
-        start = (INDEX_OF_LAST_TUTORIAL_SEGMENT + 1) + STARTPOINT_MAINSTORY.index();
         end = (INDEX_OF_LAST_TUTORIAL_SEGMENT + 1) + ENDPOINT_MAINSTORY.index();     
     }
+    
+    return end;
+}
+
+
+void AutoStory::run_autostory(SingleSwitchProgramEnvironment& env, ProControllerContext& context){
+    AutoStoryOptions options{
+        LANGUAGE,
+        STARTERCHOICE,
+        NOTIFICATION_STATUS_UPDATE
+    };    
 
-    for (size_t segment_index = start; segment_index <= end; segment_index++){
+    for (size_t segment_index = get_start_segment_index(); segment_index <= get_end_segment_index(); segment_index++){
         ALL_AUTO_STORY_SEGMENT_LIST()[segment_index]->run_segment(env, context, options);
     }
 }
@@ -777,7 +790,7 @@ void AutoStory::program(SingleSwitchProgramEnvironment& env, ProControllerContex
 
     // Set settings. to ensure autosave is off.
     if (CHANGE_SETTINGS){
-        change_settings_prior_to_autostory(env, context, STARTPOINT_TUTORIAL.index(), LANGUAGE);
+        change_settings_prior_to_autostory(env, context, get_start_segment_index(), LANGUAGE);
     }
 
     run_autostory(env, context);

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStory.h

@@ -50,6 +50,9 @@ class AutoStory : public SingleSwitchProgramInstance, public ConfigOption::Liste
         int loop, int start_loop, int end_loop
     );
 
+    size_t get_start_segment_index();
+    size_t get_end_segment_index();
+
     void run_autostory(SingleSwitchProgramEnvironment& env, ProControllerContext& context);
 
 private:

SerialPrograms/Source/PokemonSV/Programs/AutoStory/PokemonSV_AutoStoryTools.cpp

@@ -583,29 +583,65 @@ void change_settings_prior_to_autostory(
     size_t current_segment_num,
     Language language
 ){
-    if (current_segment_num == 0){  // can't change settings in the intro cutscene
-        return;
-    }
 
     // get index of `Options` in the Main Menu, which depends on where you are in Autostory
     int8_t options_index;  
     switch(current_segment_num){
         case 0:
+            return; // can't change settings in the intro cutscene
+        case 1:
+        // after Intro cutscene done, in room
+            // Menu
+            // - Options
+            // - Save        
             options_index = 0;
             break;
-        case 1:
+        case 2:
+            // Menu
+            // - Bag  --> unlocked after picked up bag/hat in room. Segment 01, checkpoint 02
+            // - Options
+            // - Save
             options_index = 1;
             break;
+        case 3:
+        case 4:
+        case 5:
+        case 6:
+            // Menu
+            // - Bag
+            // - Boxes --> unlocked after battling Nemona and receiving Pokedex app. Segment 02, checkpoint 04
+            // - Options
+            // - Save        
+            options_index = 2;
+            break;
+        case 7:
+        case 8:
+        case 9:
+            // Menu
+            // - Bag
+            // - Boxes
+            // - Poke Portal --> unlocked after arriving at Los Platos and talking to Nemona. Segment 06, checkpoint 11
+            // - Options
+            // - Save  
+            options_index = 3;
+            break;                    
         default:
-            options_index = 2;        
+            // Menu
+            // - Bag
+            // - Boxes
+            // - Picnic --> unlocked after finishing tutorial. Segment 09, checkpoint 20
+            // - Poke Portal
+            // - Options
+            // - Save          
+            options_index = 4;        
             break;
     }
 
-    bool has_minimap = current_segment_num > 1;  // the minimap only shows up in segment 2 and beyond
+    bool has_minimap = current_segment_num >= 2;  // the minimap only shows up in segment 2 and beyond
 
     enter_menu_from_overworld(env.program_info(), env.console, context, options_index, MenuSide::RIGHT, has_minimap);
     change_settings(env, context, language);
-    if(has_minimap){
+    if(!has_minimap){
         pbf_mash_button(context, BUTTON_B, 2 * TICKS_PER_SECOND);
     }else{
         press_Bs_to_back_to_overworld(env.program_info(), env.console, context);