Update float option UI behavior.

Author: Mysticial

Common/Cpp/Options/FloatingPointOption.cpp

@@ -89,6 +89,17 @@ std::string FloatingPointCell::set(double x){
     }
     return err;
 }
+void FloatingPointCell::set_and_sanitize(double x){
+    if (std::isnan(x)){
+        x = 0;
+    }
+    const Data& data = *m_data;
+    x = std::max(x, data.m_min_value);
+    x = std::min(x, data.m_max_value);
+    if (x != m_data->m_current.exchange(x, std::memory_order_relaxed)){
+        report_value_changed(this);
+    }
+}
 
 void FloatingPointCell::load_json(const JsonValue& json){
     double value;

Common/Cpp/Options/FloatingPointOption.h

@@ -38,6 +38,7 @@ class FloatingPointCell : public ConfigOption{
 
     operator double() const;
     std::string set(double x);
+    void set_and_sanitize(double x);
 
     virtual void load_json(const JsonValue& json) override;
     virtual JsonValue to_json() const override;

Common/Qt/Options/FloatingPointWidget.cpp

@@ -10,12 +10,16 @@
 #include "ConfigWidget.h"
 #include "FloatingPointWidget.h"
 
+//#include <iostream>
+//using std::cout;
+//using std::endl;
+
 namespace PokemonAutomation{
 
 
 
 ConfigWidget* FloatingPointCell::make_QtWidget(QWidget& parent){
-    return new FloatingPointCellWidget(parent, *this);
+    return new FloatingPointCellWidget(parent, *this, true);
 }
 ConfigWidget* FloatingPointOption::make_QtWidget(QWidget& parent){
     return new FloatingPointOptionWidget(parent, *this);
@@ -27,7 +31,7 @@ ConfigWidget* FloatingPointOption::make_QtWidget(QWidget& parent){
 FloatingPointCellWidget::~FloatingPointCellWidget(){
     m_value.remove_listener(*this);
 }
-FloatingPointCellWidget::FloatingPointCellWidget(QWidget& parent, FloatingPointCell& value)
+FloatingPointCellWidget::FloatingPointCellWidget(QWidget& parent, FloatingPointCell& value, bool sanitize)
     : QLineEdit(QString::number(value, 'f'), &parent)
     , ConfigWidget(value, *this)
     , m_value(value)
@@ -48,17 +52,23 @@ FloatingPointCellWidget::FloatingPointCellWidget(QWidget& parent, FloatingPointC
     );
     connect(
         this, &QLineEdit::editingFinished,
-        this, [this](){
+        this, [this, sanitize](){
             bool ok;
             double current = this->text().toDouble(&ok);
             QPalette palette;
-            if (ok && m_value.check_validity(current).empty()){
-                palette.setColor(QPalette::Text, Qt::black);
+            palette.setColor(QPalette::Text, Qt::black);
+            if (sanitize){
+                m_value.set_and_sanitize(current);
             }else{
-                palette.setColor(QPalette::Text, Qt::red);
+                if (!ok || !m_value.check_validity(current).empty()){
+                    palette.setColor(QPalette::Text, Qt::red);
+                }
+                m_value.set(current);
             }
             this->setPalette(palette);
-            m_value.set(current);
+
+            //  Always update the UI.
+            on_config_value_changed(this);
         }
     );
     value.add_listener(*this);
@@ -91,7 +101,7 @@ FloatingPointOptionWidget::FloatingPointOptionWidget(QWidget& parent, FloatingPo
     text->setTextInteractionFlags(Qt::TextBrowserInteraction);
     text->setOpenExternalLinks(true);
     layout->addWidget(text, 1);
-    m_cell = new FloatingPointCellWidget(*this, value);
+    m_cell = new FloatingPointCellWidget(*this, value, false);
     layout->addWidget(m_cell, 1);
     value.add_listener(*this);
 }

Common/Qt/Options/FloatingPointWidget.h

@@ -17,7 +17,7 @@ namespace PokemonAutomation{
 class FloatingPointCellWidget : public QLineEdit, public ConfigWidget{
 public:
     ~FloatingPointCellWidget();
-    FloatingPointCellWidget(QWidget& parent, FloatingPointCell& value);
+    FloatingPointCellWidget(QWidget& parent, FloatingPointCell& value, bool sanitize);
 
     virtual void update_value() override;
     virtual void on_config_value_changed(void* object) override;