fix warning on clang

Author: Gin

SerialPrograms/CMakeLists.txt

@@ -2609,11 +2609,14 @@ else() # macOS and Linux
     endif()
 
     if (APPLE)
-        # Add -Wno-c11-extensions to avoid clang gives
+        ###################################################
+        # Compiler flag change history:
+        # Removed -Wno-c11-extensions since we no long have following error:
         # /usr/local/Cellar/opencv/4.5.5_3/include/opencv4/opencv2/core/mat.inl.hpp:2116:9: error: '_Atomic' is a C11 extension
         # when compiling OpenCV
-        # target_compile_options(SerialPrograms PRIVATE -Wall -Wextra -Wpedantic -Werror -Wno-c11-extensions)
-        target_compile_options(SerialPrograms PRIVATE -Wall -Wextra -Wpedantic -Werror -Wshorten-64-to-32)
+        ###################################################
+        # Use https://clang.llvm.org/docs/DiagnosticsReference.html to query Clang warnings
+        target_compile_options(SerialPrograms PRIVATE -Wall -Wextra -Wpedantic -Werror -Wshorten-64-to-32 -Wtautological-constant-in-range-compare -Wsequence-point)
     else()
         # Assume GCC
         target_compile_options(SerialPrograms PRIVATE -Wall -Wextra -Wpedantic -Werror -fno-strict-aliasing)

SerialPrograms/Source/ML/Programs/ML_LabelImages.cpp

@@ -263,7 +263,7 @@ void LabelImages::update_rendered_objects(){
         }
         create_overlay_for_index(i_obj);
     }
-    if (m_selected_obj_idx >= 0 && m_selected_obj_idx < m_annotations.size()){
+    if (m_selected_obj_idx < m_annotations.size()){
         create_overlay_for_index(m_selected_obj_idx);
     }
 }