Skip to content

Commit 9027300

Browse files
MysticialMysticial
committed
Rename ConfigOption::Listener methods.
1 parent a545134 commit 9027300

File tree

105 files changed

+158
-159
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

105 files changed

+158
-159
lines changed

‎Common/Cpp/Options/ConfigOption.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,17 +115,17 @@ void ConfigOption::set_visibility(ConfigOptionState visibility){
115115
void ConfigOption::report_visibility_changed(){
116116
auto scope = m_lifetime_sanitizer.check_scope();
117117
Data& data = *m_data;
118-
data.listeners.run_method_unique(&Listener::visibility_changed);
118+
data.listeners.run_method_unique(&Listener::on_config_visibility_changed);
119119
}
120120
void ConfigOption::report_program_state(bool program_is_running){
121121
auto scope = m_lifetime_sanitizer.check_scope();
122122
Data& data = *m_data;
123-
data.listeners.run_method_unique(&Listener::program_state_changed, program_is_running);
123+
data.listeners.run_method_unique(&Listener::on_program_state_changed, program_is_running);
124124
}
125125
void ConfigOption::report_value_changed(void* object){
126126
auto scope = m_lifetime_sanitizer.check_scope();
127127
Data& data = *m_data;
128-
data.listeners.run_method_unique(&Listener::value_changed, object);
128+
data.listeners.run_method_unique(&Listener::on_config_value_changed, object);
129129
}
130130

131131

‎Common/Cpp/Options/ConfigOption.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ class ConfigOption{
4242
struct Listener{
4343
// Pass the object that initiated the change. This is mainly used to
4444
// identify yourself as the initiater to avoid infinite loops.
45-
virtual void value_changed(void* object){}
46-
virtual void visibility_changed(){}
47-
virtual void program_state_changed(bool program_is_running){}
45+
virtual void on_config_value_changed(void* object){}
46+
virtual void on_config_visibility_changed(){}
47+
virtual void on_program_state_changed(bool program_is_running){}
4848
};
4949
void add_listener(Listener& listener);
5050
void remove_listener(Listener& listener);

‎Common/Qt/Options/BatchWidget.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ void BatchWidget::update_value(){
5454
item->update_value();
5555
}
5656
}
57-
void BatchWidget::value_changed(void* object){
57+
void BatchWidget::on_config_value_changed(void* object){
5858
QMetaObject::invokeMethod(this, [this]{
5959
update_value();
6060
}, Qt::QueuedConnection);

‎Common/Qt/Options/BatchWidget.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class BatchWidget : public QWidget, public ConfigWidget{
2121
BatchWidget(QWidget& parent, BatchOption& value);
2222

2323
virtual void update_value() override;
24-
virtual void value_changed(void* object) override;
24+
virtual void on_config_value_changed(void* object) override;
2525

2626
protected:
2727
BatchOption& m_value;

‎Common/Qt/Options/BooleanCheckBoxWidget.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ void BooleanCheckBoxCellWidget::update_value(){
6060
m_box->setChecked(m_value);
6161
}
6262
}
63-
void BooleanCheckBoxCellWidget::value_changed(void* object){
63+
void BooleanCheckBoxCellWidget::on_config_value_changed(void* object){
6464
QMetaObject::invokeMethod(this, [this]{
6565
update_value();
6666
}, Qt::QueuedConnection);
@@ -112,7 +112,7 @@ void BooleanCheckBoxOptionWidget::update_value(){
112112
m_box->setChecked(m_value);
113113
}
114114
}
115-
void BooleanCheckBoxOptionWidget::value_changed(void* object){
115+
void BooleanCheckBoxOptionWidget::on_config_value_changed(void* object){
116116
QMetaObject::invokeMethod(m_box, [this]{
117117
update_value();
118118
}, Qt::QueuedConnection);

‎Common/Qt/Options/BooleanCheckBoxWidget.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class BooleanCheckBoxCellWidget : public QWidget, public ConfigWidget{
2121
BooleanCheckBoxCellWidget(QWidget& parent, BooleanCheckBoxCell& value);
2222

2323
virtual void update_value() override;
24-
virtual void value_changed(void* object) override;
24+
virtual void on_config_value_changed(void* object) override;
2525

2626
private:
2727
BooleanCheckBoxCell& m_value;
@@ -37,7 +37,7 @@ class BooleanCheckBoxOptionWidget : public QWidget, public ConfigWidget{
3737
BooleanCheckBoxOptionWidget(QWidget& parent, BooleanCheckBoxOption& value);
3838

3939
virtual void update_value() override;
40-
virtual void value_changed(void* object) override;
40+
virtual void on_config_value_changed(void* object) override;
4141

4242
private:
4343
BooleanCheckBoxOption& m_value;

‎Common/Qt/Options/ButtonWidget.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void ButtonCellWidget::update_value(){
7070
}
7171
// cout << "Update: " << this->font().pointSize() << endl;
7272
}
73-
void ButtonCellWidget::value_changed(void* object){
73+
void ButtonCellWidget::on_config_value_changed(void* object){
7474
QMetaObject::invokeMethod(this, [this]{
7575
update_value();
7676
}, Qt::QueuedConnection);
@@ -138,7 +138,7 @@ void ButtonOptionWidget::update_value(){
138138
}
139139
// cout << "Update: " << this->font().pointSize() << endl;
140140
}
141-
void ButtonOptionWidget::value_changed(void* object){
141+
void ButtonOptionWidget::on_config_value_changed(void* object){
142142
QMetaObject::invokeMethod(this, [this]{
143143
update_value();
144144
}, Qt::QueuedConnection);

‎Common/Qt/Options/ButtonWidget.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ButtonCellWidget : public QWidget, public ConfigWidget{
2323
ButtonCellWidget(QWidget& parent, ButtonCell& value);
2424

2525
virtual void update_value() override;
26-
virtual void value_changed(void* object) override;
26+
virtual void on_config_value_changed(void* object) override;
2727

2828
private:
2929
ButtonCell& m_value;
@@ -40,7 +40,7 @@ class ButtonOptionWidget : public QWidget, public ConfigWidget{
4040
ButtonOptionWidget(QWidget& parent, ButtonOption& value);
4141

4242
virtual void update_value() override;
43-
virtual void value_changed(void* object) override;
43+
virtual void on_config_value_changed(void* object) override;
4444

4545
private:
4646
ButtonOption& m_value;

‎Common/Qt/Options/ColorWidget.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void ColorCellWidget::update_value(){
5555
m_line_edit->setText(str);
5656
m_box->setText("<font color=\"#" + str + "\">&#x2b24;</font>");
5757
}
58-
void ColorCellWidget::value_changed(void* object){
58+
void ColorCellWidget::on_config_value_changed(void* object){
5959
QMetaObject::invokeMethod(this, [this]{
6060
update_value();
6161
}, Qt::QueuedConnection);

‎Common/Qt/Options/ColorWidget.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ class ColorCellWidget : public QWidget, public ConfigWidget{
2424
ColorCellWidget(QWidget& parent, ColorCell& value);
2525

2626
virtual void update_value() override;
27-
virtual void value_changed(void* object) override;
27+
virtual void on_config_value_changed(void* object) override;
2828

2929

3030
private:

0 commit comments

Comments
 (0)