Fix controller error behavior. Make unknown program ID versioning work.

Author: Mysticial

SerialPrograms/Source/Controllers/ControllerSession.cpp

@@ -301,6 +301,12 @@ std::string ControllerSession::reset(bool clear_settings){
 //                return "No connection set.";
 //            }
 
+//            cout << "Checking readiness... " << (int)m_desired_controller << endl;
+            if (m_connection && m_connection->is_ready()){
+                m_desired_controller = m_connection->current_controller();
+//                cout << "Ready! - " << (int)m_desired_controller << endl;
+            }
+
             //  Move these out to indicate that we should no longer access them.
             controller = std::move(m_controller);
             connection = std::move(m_connection);
@@ -358,7 +364,11 @@ void ControllerSession::post_connection_ready(ControllerConnection& connection){
         }
 
         reset_mode = m_next_reset_mode;
+
+        supported_controllers = m_connection->controller_list();
+        current_controller = m_connection->current_controller();
     }
+    signal_controller_changed(current_controller, supported_controllers);
 
     //  Construct the controller.
     if (desired_controller != ControllerType::None){
@@ -389,7 +399,6 @@ void ControllerSession::post_connection_ready(ControllerConnection& connection){
 //        cout << "current_controller = " << CONTROLLER_TYPE_STRINGS.get_string(current_controller) << endl;
         ready = m_controller && m_controller->is_ready();
     }
-
     signal_controller_changed(current_controller, supported_controllers);
     signal_ready_changed(ready);
     signal_status_text_changed(status_text());

SerialPrograms/Source/Controllers/SerialPABotBase/SerialPABotBase.cpp

@@ -23,8 +23,6 @@ const std::map<pabb_ProgramID, uint32_t>& SUPPORTED_DEVICES(){
         {PABB_PID_PABOTBASE_TeensyPP2,          2025090300},
         {PABB_PID_PABOTBASE_ESP32,              2025090300},
         {PABB_PID_PABOTBASE_ESP32S3,            2025090300},
-        {PABB_PID_PABOTBASE_PicoW_USB,          2025090300},
-        {PABB_PID_PABOTBASE_PicoW_UART,         2025090300},
     };
     return database;
 }

SerialPrograms/Source/Controllers/SerialPABotBase/SerialPABotBase_Connection.cpp

@@ -179,10 +179,17 @@ ControllerType SerialPABotBase_Connection::process_device(bool set_to_null_contr
     if (PROGRAMS.find(m_program_id) == PROGRAMS.end()){
 #if 1
         m_logger.Logger::log(
-            "Unrecognized Program ID: 0x" + tostr_hex(m_program_id) + " for this protocol version. "
+            "Unrecognized Program ID: (0x" + tostr_hex(m_program_id) + ") for this protocol version. "
             "Compatibility is not guaranteed.",
             COLOR_RED
         );
+        if (PROGRAMS.find(PABB_PID_UNSPECIFIED) == PROGRAMS.end()){
+            throw SerialProtocolException(
+                m_logger, PA_CURRENT_FUNCTION,
+                "Unrecognized program IDs require latest protocol.<br>"
+                "Program ID: 0x" + tostr_hex(m_program_id) + ", Device Protocol: " + std::to_string(m_protocol)
+            );
+        }
 #else
         throw SerialProtocolException(
             m_logger, PA_CURRENT_FUNCTION,
@@ -288,7 +295,7 @@ void SerialPABotBase_Connection::thread_body(bool set_to_null_controller){
             error = e.message();
         }
         if (!error.empty()){
-            m_ready.store(false, std::memory_order_relaxed);
+//            m_ready.store(false, std::memory_order_relaxed);
             set_status_line0(error, COLOR_RED);
 //            signal_pre_not_ready();
             m_botbase->stop();