Remove pro controller requirement from programs that don't use the controller. Tweak the Regice light pattern for ESP32. Automatically change controller dropdown to match what's on the ESP32.

Author: Mysticial

SerialPrograms/Source/Controllers/ControllerSession.cpp

@@ -5,6 +5,7 @@
  */
 
 #include "Common/Cpp/Exceptions.h"
+#include "ControllerTypeStrings.h"
 #include "ControllerSession.h"
 
 //#include <iostream>
@@ -350,6 +351,7 @@ void ControllerSession::post_connection_ready(
         m_available_controllers = available_controllers;
 
 
+#if 0
         auto iter = supported_controllers.begin();
         if (supported_controllers.size() == 1){
             //  Only one controller available. Force the option to it.
@@ -361,6 +363,7 @@ void ControllerSession::post_connection_ready(
                 current_controller = m_option.m_controller_type;
             }
         }
+#endif
 
         //  Construct the controller.
         if (current_controller != ControllerType::None){
@@ -373,6 +376,7 @@ void ControllerSession::post_connection_ready(
         }
 
         //  Commit all changes.
+//        cout << "current_controller = " << CONTROLLER_TYPE_STRINGS.get_string(current_controller) << endl;
         m_option.m_controller_type = current_controller;
         ready = m_controller && m_controller->is_ready();
 

SerialPrograms/Source/NintendoSwitch/Programs/NintendoSwitch_SnapshotDumper.cpp

@@ -22,7 +22,7 @@ SnapshotDumper_Descriptor::SnapshotDumper_Descriptor()
         "Periodically take screenshots.",
         FeedbackType::NONE,
         AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController}
+        {}
     )
 {}
 

SerialPrograms/Source/NintendoSwitch/Programs/NintendoSwitch_SwitchViewer.cpp

@@ -23,7 +23,7 @@ SwitchViewer_Descriptor::SwitchViewer_Descriptor()
         "ComputerControl/blob/master/Wiki/Programs/NintendoSwitch/SwitchViewer.md",
         "View status information from one or more running programs."
     )
-    , m_requirements({ControllerFeature::NintendoSwitch_ProController})
+    , m_requirements({})
 {}
 
 

SerialPrograms/Source/PokemonBDSP/Programs/TestPrograms/PokemonBDSP_ShinyEncounterTester.cpp

@@ -21,7 +21,7 @@ ShinyEncounterTester_Descriptor::ShinyEncounterTester_Descriptor()
         "",
         "Test the shiny encounter detector. Start this program just before an encounter.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController},
+        {},
         FasterIfTickPrecise::NOT_FASTER
     )
 {}

SerialPrograms/Source/PokemonBDSP/Programs/TestPrograms/PokemonBDSP_SoundListener.cpp

@@ -35,7 +35,7 @@ SoundListener_Descriptor::SoundListener_Descriptor()
         "",
         "Test sound detectors listening to audio stream.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController}
+        {}
     )
 {}
 

SerialPrograms/Source/PokemonLA/Programs/TestPrograms/PokemonLA_MountDetectionTest.cpp

@@ -22,7 +22,7 @@ MountDetectionTest_Descriptor::MountDetectionTest_Descriptor()
         "",
         "Test the mount detection in the bottom right corner.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController},
+        {},
         FasterIfTickPrecise::NOT_FASTER
     )
 {}

SerialPrograms/Source/PokemonLA/Programs/TestPrograms/PokemonLA_OverworldWatcher.cpp

@@ -26,7 +26,7 @@ OverworldWatcher_Descriptor::OverworldWatcher_Descriptor()
         "This is a test program that simply observes the game and labels things of interest. "
         "This program doesn't really do anything.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController},
+        {},
         FasterIfTickPrecise::NOT_FASTER
     )
 {}

SerialPrograms/Source/PokemonLA/Programs/TestPrograms/PokemonLA_SoundListener.cpp

@@ -41,7 +41,7 @@ SoundListener_Descriptor::SoundListener_Descriptor()
         "",
         "Test sound detectors listening to audio stream.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController}
+        {}
     )
 {}
 

SerialPrograms/Source/PokemonSV/Programs/TestPrograms/PokemonSV_SoundListener.cpp

@@ -27,7 +27,7 @@ SoundListener_Descriptor::SoundListener_Descriptor()
         "",
         "Test sound detectors listening to audio stream.",
         FeedbackType::REQUIRED, AllowCommandsWhenRunning::ENABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController}
+        {}
     )
 {}
 

SerialPrograms/Source/PokemonSwSh/InferenceTraining/PokemonSwSh_GenerateIVCheckerOCR.cpp

@@ -36,7 +36,7 @@ GenerateIVCheckerOCR_Descriptor::GenerateIVCheckerOCR_Descriptor()
         "Generate IV Checker OCR Data",
         FeedbackType::REQUIRED,
         AllowCommandsWhenRunning::DISABLE_COMMANDS,
-        {ControllerFeature::NintendoSwitch_ProController}
+        {}
     )
 {}