fix box cursor detection

Author: Gin

SerialPrograms/Source/PokemonLZA/Inference/Boxes/PokemonLZA_BoxDetection.cpp

@@ -5,6 +5,7 @@
  */
 
 #include "Common/Cpp/Exceptions.h"
+#include "CommonFramework/Exceptions/FatalProgramException.h"
 #include "CommonFramework/ImageTools/ImageStats.h"
 #include "CommonFramework/VideoPipeline/VideoOverlay.h"
 #include "CommonFramework/VideoPipeline/VideoOverlayScopes.h"
@@ -102,7 +103,7 @@ bool BoxDetector::detect_at_cell(const ImageViewRGB32& image_crop){
 
     const size_t total_crop_area = image_crop.width() * image_crop.height();
     const size_t min_area = static_cast<size_t>(total_crop_area / 60.0);
-    const size_t max_area = static_cast<size_t>(total_crop_area / 15.0);
+    const size_t max_area = static_cast<size_t>(total_crop_area / 10.0);
 
     int saved_object_id = 0;
     if (debug_switch){
@@ -181,17 +182,19 @@ bool BoxDetector::detect(const ImageViewRGB32& screen){
                 debug_switch = false;
             }
             if (detected){
-                // if (arrow_found){
-                //     throw FatalProgramException(ErrorReport::SEND_ERROR_REPORT,
-                //         "Multiple box selection arrows detected!", nullptr, screen.copy());
-                // }
+                if (arrow_found && m_debug_mode){
+                    cout << "Multiple box selection arrows detected! First detection (" << int(m_found_row) << ", " << int(m_found_col) << ")"
+                         << " second detection (" << int(row) << ", " << int(col) << ")" << endl;
+                    throw FatalProgramException(ErrorReport::SEND_ERROR_REPORT,
+                        "Multiple box selection arrows detected!", nullptr, screen.copy());
+                }
                 arrow_found = true;
                 m_found_row = row;
                 m_found_col = col;
                 break;
             }
         }
-        if (arrow_found){
+        if (arrow_found && !m_debug_mode){
             break;
         }
     }

SerialPrograms/Source/PokemonLZA/Inference/Boxes/PokemonLZA_BoxDetection.h

@@ -55,6 +55,10 @@ class BoxDetector : public StaticScreenDetector{
         uint8_t row, uint8_t col
     );
 
+    // Under debug mode, will throw FatalProgramException when more than one box cell
+    // detects a cursor. This is used for debugging.
+    void set_debug_mode(bool debug_mode) { m_debug_mode = debug_mode; }
+
 private:
     // called for each box cell to check if the selection arrow is above that cell
     bool detect_at_cell(const ImageViewRGB32& image_crop);
@@ -65,6 +69,7 @@ class BoxDetector : public StaticScreenDetector{
     std::vector<ImageFloatBox> m_arrow_boxes;  // all 6 x 6 potential locations of the arrow interiors on box view
     uint8_t m_found_row = 0;
     uint8_t m_found_col = 0;
+    bool m_debug_mode = false;
 };
 
 class BoxWatcher : public DetectorToFinder<BoxDetector>{

SerialPrograms/Source/PokemonLZA/Inference/Boxes/PokemonLZA_BoxInfoDetector.cpp

@@ -127,7 +127,8 @@ bool BoxAlphaDetector::detect(const ImageViewRGB32& screen){
     size_t min_area = size_t(screen_rel_size_2 * min_area_1080p);
 
     const std::vector<std::pair<uint32_t, uint32_t>> FILTERS = {
-        {combine_rgb(200, 50, 50), combine_rgb(255, 150, 100)},
+        // {combine_rgb(200, 50, 50), combine_rgb(255, 150, 150)},
+        {combine_rgb(200, 50, 50), combine_rgb(255, 150, 150)},
         {combine_rgb(200, 50, 50), combine_rgb(255, 100, 100)},
         {combine_rgb(150, 0, 0), combine_rgb(255, 100, 100)},
     };

SerialPrograms/Source/Tests/CommandLineTests.cpp

@@ -53,8 +53,10 @@ void print_equals(){
             _ret = test_func(file_path); \
         } catch (const std::exception& e) { \
             cout << "Test: " << (file_path) << " threw exception: " << e.what() << endl; \
+            _ret = 1; \
         } catch (const Exception& e) {\
            cout << "Test: " << (file_path) << " threw " << e.name() << ": <<<" << e.message() << ">>>" << endl; \
+           _ret = 1; \
         } \
         if (_ret > 0) {\
             print_equals(); \

SerialPrograms/Source/Tests/PokemonLZA_Tests.cpp

@@ -195,6 +195,7 @@ int test_pokemonLZA_BoxCellInfoDetector(const ImageViewRGB32& image, const std::
 
     // Test BoxDetector for row and col
     BoxDetector box_detector(COLOR_RED, &overlay);
+    box_detector.set_debug_mode(true);
     bool in_box_system = box_detector.detect(image);
     if (!in_box_system){
         cerr << "Error: BoxDetector did not detect box system view." << endl;