Rework warning supression (#610)

Author: pifopi

3rdParty/dpp/DPP_SilenceWarnings.h

@@ -1851,10 +1851,8 @@ template<typename _Tp> inline
 _Tp Rect_<_Tp>::area() const
 {
     const _Tp result = width * height;
-    if constexpr (std::numeric_limits<_Tp>::is_integer)
-    {
-        CV_DbgAssert(width == 0 || result / width == height); // make sure the result fits in the return value
-    }
+    CV_DbgAssert(!std::numeric_limits<_Tp>::is_integer
+        || width == 0 || result / width == height); // make sure the result fits in the return value
     return result;
 }
 

3rdParty/opencv-4.11.0/opencv2/core/types.hpp

@@ -4,7 +4,6 @@
 #include <QFileInfo>
 //#include <QTextStream>
 #include <QMessageBox>
-#include <dpp/DPP_SilenceWarnings.h>
 #include <Integrations/DppIntegration/DppClient.h>
 #include "Common/Cpp/Exceptions.h"
 #include "Common/Cpp/ImageResolution.h"

SerialPrograms/Source/CommonFramework/Main.cpp

@@ -5,7 +5,6 @@
  */
 
 #include <QFile>
-#include <dpp/DPP_SilenceWarnings.h>
 #include <Integrations/DppIntegration/DppClient.h>
 #include "Common/Cpp/PrettyPrint.h"
 #include "Common/Cpp/Json/JsonValue.h"

SerialPrograms/Source/CommonFramework/Notifications/ProgramNotifications.cpp

@@ -38,7 +38,7 @@ class PanelInstance{
 public:
     //  Serialization
     void from_json();
-    virtual void from_json(const JsonValue& json){}
+    virtual void from_json([[maybe_unused]] const JsonValue& json){}
     virtual JsonValue to_json() const;
 
 protected:

SerialPrograms/Source/CommonFramework/Panels/PanelInstance.h

@@ -7,7 +7,6 @@
 #include <QHBoxLayout>
 #include <QLabel>
 #include <QPushButton>
-#include <dpp/DPP_SilenceWarnings.h>
 #include "Common/Qt/StringToolsQt.h"
 //#include "CommonFramework/Globals.h"
 //#include "CommonFramework/GlobalSettingsPanel.h"
@@ -122,7 +121,7 @@ DiscordIntegrationSettingsOption::DiscordIntegrationSettingsOption()
     this->add_listener(*this);
     library0.add_listener(*this);
 }
-void DiscordIntegrationSettingsOption::on_config_value_changed(void* object){
+void DiscordIntegrationSettingsOption::on_config_value_changed([[maybe_unused]] void* object){
 //    cout << this->enabled() << endl;
 #if (defined PA_SLEEPY || defined PA_DPP)
     bool options_enabled = this->enabled();

SerialPrograms/Source/Integrations/DiscordIntegrationSettings.cpp

@@ -1,7 +1,6 @@
 #ifdef PA_DPP
 
 #include <set>
-#include <dpp/DPP_SilenceWarnings.h>
 #include <dpp/dpp.h>
 #include <Integrations/DppIntegration/DppClient.h>
 #include <Integrations/DppIntegration/DppCommandHandler.h>

SerialPrograms/Source/Integrations/DppIntegration/DppClient.cpp

@@ -1,7 +1,6 @@
 #ifdef PA_DPP
 
 #include <format>
-#include <dpp/DPP_SilenceWarnings.h>
 #include <dpp/dpp.h>
 #include "Common/Cpp/Concurrency/ScheduledTaskRunner.h"
 #include "CommonFramework/Globals.h"

SerialPrograms/Source/Integrations/DppIntegration/DppCommandHandler.cpp

@@ -1,6 +1,5 @@
 #ifdef PA_DPP
 
-#include <dpp/DPP_SilenceWarnings.h>
 #include <dpp/dpp.h>
 #include <Integrations/DppIntegration/DppUtility.h>
 #include "CommonFramework/GlobalSettingsPanel.h"

SerialPrograms/Source/Integrations/DppIntegration/DppUtility.cpp

@@ -251,7 +251,7 @@ void LabelImages::load_image_related_data(const std::string& image_path, size_t
         return; // no embedding, then no way for us to annotate
     }
     // see if we can load the previously created labels
-    const std::string anno_filename = std::filesystem::path(image_path).filename().replace_extension(".json");
+    const std::string anno_filename = std::filesystem::path(image_path).filename().replace_extension(".json").string();
 
     // ensure the folder exists
     std::filesystem::create_directory(ML_ANNOTATION_PATH());
@@ -284,7 +284,7 @@ void LabelImages::load_image_related_data(const std::string& image_path, size_t
         try{
             ObjectAnnotation anno_obj = json_to_object_annotation((*json_array)[i]);
             m_annotated_objects.emplace_back(std::move(anno_obj));
-        } catch(JsonParseException & e){
+        } catch([[maybe_unused]] JsonParseException & e){
             m_fail_to_load_annotation_file = true;
             QMessageBox box;
             box.warning(nullptr, "Unable to Load Annotation",