fix flat white dialog detector

Author: Gin

SerialPrograms/Source/CommonTools/Images/SolidColorTest.cpp

@@ -73,15 +73,15 @@ bool is_solid(
 ){
     double stddev = stats.stddev.sum();
     if (stddev > max_stddev_sum){
-//        cout << "bad stddev = " << stddev << endl;
+        // cout << "bad stddev = " << stddev << endl;
         return false;
     }
 
     double average = stats.average.sum();
     FloatPixel actual = stats.average / average;
     double distance = euclidean_distance(actual, expected_color_ratio);
-//    cout << "actual color ratio " << actual << endl;
-//    cout << "distance = " << distance << endl;
+    // cout << "actual color ratio " << actual << endl;
+    // cout << "distance = " << distance << endl;
 
     return distance <= max_euclidean_distance;
 }

SerialPrograms/Source/PokemonLZA/Inference/PokemonLZA_DialogDetector.cpp

@@ -14,9 +14,9 @@
 #include "CommonFramework/VideoPipeline/VideoOverlay.h"
 #include "CommonFramework/VideoPipeline/VideoOverlayScopes.h"
 
-//#include <iostream>
-//using std::cout;
-//using std::endl;
+// #include <iostream>
+// using std::cout;
+// using std::endl;
 
 namespace PokemonAutomation{
 namespace NintendoSwitch{
@@ -219,7 +219,7 @@ void FlatWhiteDialogDetector::make_overlays(VideoOverlaySet& items) const{
     items.add(m_color, m_arrow_box);
 }
 bool FlatWhiteDialogDetector::detect(const ImageViewRGB32& screen){
-    if (!is_white(extract_box_reference(screen, m_top), 500, 20)){
+    if (!is_white(extract_box_reference(screen, m_top), 500.0, 20.0)){
         m_last_detected_box.reset();
         return false;
     }

SerialPrograms/Source/Tests/PokemonLZA_Tests.cpp

@@ -38,11 +38,19 @@ int test_pokemonZLA_NormalDialogBoxDetector(const ImageViewRGB32& image, bool ta
     auto& logger = global_logger_command_line();
     auto overlay = DummyVideoOverlay();
     const bool stop_on_detected = true;
-    NormalDialogDetector detector(logger, overlay, stop_on_detected); 
+    NormalDialogDetector detector(logger, overlay, stop_on_detected);
     bool result = detector.process_frame(image, current_time());
     TEST_RESULT_EQUAL(result, target);
     return 0;
 }
 
+int test_pokemonLZA_FlatWhiteDialogDetector(const ImageViewRGB32& image, bool target){
+    auto overlay = DummyVideoOverlay();
+    FlatWhiteDialogDetector detector(COLOR_RED, &overlay);
+    bool result = detector.detect(image);
+    TEST_RESULT_EQUAL(result, target);
+    return 0;
+}
+
 
 } 

SerialPrograms/Source/Tests/PokemonLZA_Tests.h

@@ -20,8 +20,10 @@
 
 
  int test_pokemonZLA_NormalDialogBoxDetector(const ImageViewRGB32& image, bool target);
- 
+
+ int test_pokemonLZA_FlatWhiteDialogDetector(const ImageViewRGB32& image, bool target);
+
  }
- 
+
  #endif
 

SerialPrograms/Source/Tests/TestMap.cpp

@@ -289,6 +289,7 @@ const std::map<std::string, TestFunction> TEST_MAP = {
     {"PokemonSV_SandwichPlateDetector", std::bind(image_words_detector_helper, test_pokemonSV_SandwichPlateDetector, _1)},
     {"PokemonSV_RecentlyBattledDetector", std::bind(image_bool_detector_helper, test_pokemonSV_RecentlyBattledDetector, _1)},
     {"PokemonLZA_NormalDialogBoxDetector", std::bind(image_bool_detector_helper, test_pokemonZLA_NormalDialogBoxDetector, _1)},
+    {"PokemonLZA_FlatWhiteDialogDetector", std::bind(image_bool_detector_helper, test_pokemonLZA_FlatWhiteDialogDetector, _1)},
 };
 
 TestFunction find_test_function(const std::string& test_space, const std::string& test_name){