Shiny sound can play multiple times.

Author: Mysticial

SerialPrograms/Source/PokemonLZA/Options/PokemonLZA_ShinyDetectedAction.cpp

@@ -58,16 +58,25 @@ ShinyDetectedActionOption::ShinyDetectedActionOption(
         ImageAttachmentMode::JPG,
         {"Notifs", "Showcase"}
     )
+    , NOTES(
+        "<font color=\"red\">"
+        "The shiny sound is not a reliable measure of shinies encountered. "
+        "First, the sound only plays on a smaller radius than the spawn radius, so the vast majority of shinies are inaudible. "
+        "Secondly, it may play multiple times for the same shiny, so it may overcount. "
+        "You will still need to manually run around to see if any shinies spawned out-of-range.<\font>"
+    )
 {
     if (!DESCRIPTION.text().empty()){
-        PA_ADD_OPTION(DESCRIPTION);
+        PA_ADD_STATIC(DESCRIPTION);
     }
     PA_ADD_OPTION(ACTION);
     PA_ADD_OPTION(MAX_COUNT);
     PA_ADD_OPTION(TAKE_VIDEO);
     PA_ADD_OPTION(SCREENSHOT_DELAY);
 
-    on_config_value_changed(this);
+    PA_ADD_STATIC(NOTES);
+
+    ShinyDetectedActionOption::on_config_value_changed(this);
 
     ACTION.add_listener(*this);
 }

SerialPrograms/Source/PokemonLZA/Options/PokemonLZA_ShinyDetectedAction.h

@@ -35,7 +35,7 @@ class ShinyDetectedActionOption : public GroupOption, public ConfigOption::Liste
     ShinyDetectedActionOption(
         std::string label, std::string description,
         std::string default_delay,
-        ShinyDetectedActionType default_action = ShinyDetectedActionType::STOP_AFTER_COUNT
+        ShinyDetectedActionType default_action = ShinyDetectedActionType::IGNORE
     );
 
     bool stop_on_shiny(uint8_t current_count) const;
@@ -48,6 +48,8 @@ class ShinyDetectedActionOption : public GroupOption, public ConfigOption::Liste
     BooleanCheckBoxOption TAKE_VIDEO;
     MillisecondsOption SCREENSHOT_DELAY;
     EventNotificationOption NOTIFICATIONS;
+
+    StaticTextOption NOTES;
 };
 
 

SerialPrograms/Source/PokemonLZA/Programs/PokemonLZA_ShinyHunt_Bench.cpp

@@ -62,13 +62,7 @@ std::unique_ptr<StatsTracker> ShinyHunt_Bench_Descriptor::make_stats() const{
 
 
 ShinyHunt_Bench::ShinyHunt_Bench()
-    : SHINY_DETECTED(
-        "Shiny Detected",
-        "<font color=\"red\">The shiny sound plays on a smaller radius than the shiny spawn radius. "
-        "Therefore most shinies will be inaudible and will not be detected by this program. "
-        "You will still need to manually run around to see if any shinies spawned out-of-range.<\font>",
-        "2000ms"
-    )
+    : SHINY_DETECTED("Shiny Detected", "", "2000ms")
     , NOTIFICATION_STATUS("Status Update", true, false, std::chrono::seconds(3600))
     , NOTIFICATIONS({
         &NOTIFICATION_STATUS,
@@ -79,7 +73,7 @@ ShinyHunt_Bench::ShinyHunt_Bench()
     })
 {
     PA_ADD_STATIC(SHINY_REQUIRES_AUDIO);
-    PA_ADD_STATIC(SHINY_DETECTED);
+    PA_ADD_OPTION(SHINY_DETECTED);
     PA_ADD_OPTION(NOTIFICATIONS);
 }