Throttle the serial error messages.

Author: Mysticial

ClientSource/Connection/PABotBaseConnection.cpp

@@ -106,7 +106,11 @@ void PABotBaseConnection::on_recv(const void* data, size_t bytes){
 
         //  Message is too long.
         if (length > MAX_MESSAGE_SIZE){
-            m_sniffer->log("Message is too long: bytes = " + std::to_string(length));
+            char ascii = ~length;
+            std::string text = ascii < 32
+                ? ", ascii = " + std::to_string(ascii)
+                : std::string(", char = ") + ascii;
+            m_sniffer->log("Message is too long: bytes = " + std::to_string(length) + text);
             m_recv_buffer.pop_front();
             continue;
         }

ClientSource/Connection/SerialConnectionWinAPI.h

@@ -118,13 +118,24 @@ class SerialConnection : public StreamConnection{
     }
 
 private:
-    void clear_error(){
+    void process_error(const std::string& message){
+        m_errors++;
+        if (m_errors < 100 || m_errors % 1000 == 0){
+            log(message);
+        }
+
+        std::string clear_error;
         DWORD comm_error;
         if (ClearCommError(m_handle, &comm_error, nullptr) == 0){
             DWORD error = GetLastError();
-            log("ClearCommError() failed. Error = " + std::to_string(error));
+            clear_error = "ClearCommError() failed. Error = " + std::to_string(error);
+        }else{
+            clear_error = "ClearCommError error flag = " + std::to_string(comm_error);
+        }
+
+        if (m_errors < 100 || m_errors % 1000 == 0){
+            log(clear_error);
         }
-        log("ClearCommError error flag = " + std::to_string(comm_error));
     }
 
 
@@ -141,12 +152,11 @@ class SerialConnection : public StreamConnection{
         DWORD written;
         if (WriteFile(m_handle, data, (DWORD)bytes, &written, nullptr) == 0 || bytes != written){
             DWORD error = GetLastError();
-            log(
+            process_error(
                 "Failed to write: " + std::to_string(written) +
                 " / " + std::to_string(bytes) +
                 ", error = " + std::to_string(error)
             );
-            clear_error();
         }
 //        auto stop = current_time();
 //        cout << "WriteFile() : " << std::chrono::duration_cast<std::chrono::milliseconds>(stop - start).count() << endl;
@@ -164,8 +174,7 @@ class SerialConnection : public StreamConnection{
             DWORD read;
             if (ReadFile(m_handle, buffer, 32, &read, nullptr) == 0){
                 DWORD error = GetLastError();
-                log("ReadFile() failed. Error = " + std::to_string(error));
-                clear_error();
+                process_error("ReadFile() failed. Error = " + std::to_string(error));
             }
 //            auto stop = current_time();
 //            cout << "ReadFile() : " << std::chrono::duration_cast<std::chrono::milliseconds>(stop - start).count() << endl;
@@ -202,6 +211,7 @@ class SerialConnection : public StreamConnection{
 private:
     HANDLE m_handle;
     std::atomic<bool> m_exit;
+    uint64_t m_errors = 0;
     SpinLock m_send_lock;
     std::thread m_listener;
 };