Change notification text for Burmy/LeapGrinder to be less misleading.

Author: Mysticial

SerialPrograms/Source/PokemonLA/Options/PokemonLA_ShinyDetectedAction.cpp

@@ -32,10 +32,25 @@ ShinyRequiresAudioText::ShinyRequiresAudioText()
 
 
 
+
 ShinyDetectedActionOption::ShinyDetectedActionOption(
     std::string label, std::string description,
     std::string default_delay,
     ShinyDetectedAction default_action
+)
+    : ShinyDetectedActionOption(
+        label,
+        std::move(description),
+        label,
+        std::move(default_delay),
+        std::move(default_action)
+    )
+{}
+ShinyDetectedActionOption::ShinyDetectedActionOption(
+    std::string label, std::string description,
+    std::string notification_label,
+    std::string default_delay,
+    ShinyDetectedAction default_action
 )
     : GroupOption(std::move(label), LockMode::LOCK_WHILE_RUNNING)
     , DESCRIPTION(std::move(description))
@@ -58,7 +73,12 @@ ShinyDetectedActionOption::ShinyDetectedActionOption(
         LockMode::LOCK_WHILE_RUNNING,
         std::move(default_delay)
     )
-    , NOTIFICATIONS(this->label(), true, true, ImageAttachmentMode::JPG, {"Notifs", "Showcase"})
+    , NOTIFICATIONS(
+        std::move(notification_label),
+        true, true,
+        ImageAttachmentMode::JPG,
+        {"Notifs", "Showcase"}
+    )
 {
     if (!DESCRIPTION.text().empty()){
         PA_ADD_OPTION(DESCRIPTION);

SerialPrograms/Source/PokemonLA/Options/PokemonLA_ShinyDetectedAction.h

@@ -55,6 +55,12 @@ class ShinyDetectedActionOption : public GroupOption{
         std::string default_delay,
         ShinyDetectedAction default_action = ShinyDetectedAction::TAKE_VIDEO_STOP_PROGRAM
     );
+    ShinyDetectedActionOption(
+        std::string label, std::string description,
+        std::string notification_label,
+        std::string default_delay,
+        ShinyDetectedAction default_action = ShinyDetectedAction::TAKE_VIDEO_STOP_PROGRAM
+    );
 
     bool stop_on_shiny() const;
 

SerialPrograms/Source/PokemonLA/Programs/Farming/PokemonLA_LeapGrinder.cpp

@@ -113,11 +113,13 @@ LeapGrinder::LeapGrinder()
     , SHINY_DETECTED_ENROUTE(
         "Enroute Shiny Action",
         "This applies if a shiny is detected while enroute to destination.",
+        "Enroute Shiny Action",
         "0 ms"
     )
     , MATCH_DETECTED_OPTIONS(
         "Match Action",
         "What to do when the leaping Pokemon matches the *Stop On*.",
+        "Found Shiny or Alpha",
         "0 ms"
     )
     , NOTIFICATION_STATUS("Status Update", true, false, std::chrono::seconds(3600))

SerialPrograms/Source/PokemonLA/Programs/ShinyHunting/PokemonLA_BurmyFinder.cpp

@@ -100,11 +100,13 @@ BurmyFinder::BurmyFinder()
     , SHINY_DETECTED_ENROUTE(
         "Enroute Shiny Action",
         "This applies if a shiny is detected while traveling in the overworld.",
+        "Enroute Shiny Action",
         "0 ms"
     )
     , MATCH_DETECTED_OPTIONS(
         "Match Action",
         "What to do when a Burmy is found that matches the \"Stop On\" parameter.",
+        "Found Shiny or Alpha",
         "0 ms"
     )
     , NOTIFICATION_STATUS("Status Update", true, false, std::chrono::seconds(3600))