Add AzDevOps CI implementations (#631)

* Fix yaml indentation

* More format fixes

* Temporarily remove compliance reference

* Fix test job

* Fix job name

* Update image pool

* Add build results copy

* Fix build copy typo

* Param fix

* Fix build artifact download

* Remove unneeded dir from install

* Fix Pester version comaptible with tests

* Fix unit tests

* Fix unit test location

* Fix unit test path

* Disable Bash tests

* Fix testpassed

* Re-enable CygWin bash tests

* Fix cygwin check error

* Typo

* Debug bash tests

* Save config.h from build for bash tests

* Fix config.h copy

* Change test clean up

* Allow some tests to run after others fail

* Reinstate Invoke-AzDOBuild

* Fix syntax errors

* Restore opensshtestinfo

* Fix typo

* Upload bash test results

* Debug bash tests 1

* Debug 2

* Remove debug code

* Fix test path error

* Set Pester version to 3.4.6 for AppVeyor runs

Author: PaulHigin

.azdo/ci.yml

@@ -10,12 +10,12 @@ pr:
     include:
     - latestw_all
 
-resources:
-  repositories:
-  - repository: ComplianceRepo
-    type: github
-    endpoint: ComplianceGHRepo
-    name: PowerShell/compliance
+#resources:
+#  repositories:
+#  - repository: ComplianceRepo
+#    type: github
+#    endpoint: ComplianceGHRepo
+#    name: PowerShell/compliance
 
 stages:
 - stage: Build
@@ -24,7 +24,7 @@ stages:
   - job: BuildPkg
     displayName: Build Package
     pool:
-      name: 1ES
+      name: PS-PowerShell-x64
       demands:
       - ImageOverride -equals PSMMS2019-OpenSSH-Secure
 
@@ -53,19 +53,39 @@ stages:
 
     - pwsh: |
         Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
+        #
+        # Copy build artifacts
         $BuildDestPath = "$(Build.SourcesDirectory)/Win32-OpenSSH"
         if (Test-Path -Path $BuildDestPath) {
           Remove-Item -Path $BuildDestPath -Recurse -Force -ErrorAction SilentlyContinue
         }
         $null = New-Item -ItemType Directory -Path $BuildDestPath -Force
-        # Copy build artifacts
         $BuildDestx86Path = Join-Path -Path $BuildDestPath -ChildPath 'x86/Release'
-        Start-OpenSSHPackage -NativeHostArch x86 -Configuration Release -DestinationPath $BuildDestx86Path
+        Copy-BuildResults -BuildResultsPath $BuildDestx86Path -NativeHostArch x86 -Configuration Release
         $BuildDestX64Path = Join-Path -Path $BuildDestPath -ChildPath 'x64/Release'
-        Start-OpenSSHPackage -NativeHostArch x64 -Configuration Release -DestinationPath $BuildDestx64Path
+        Copy-BuildResults -BuildResultsPath $BuildDestx64Path -NativeHostArch x64 -Configuration Release
+        #
         # Upload build artifacts
+        Write-Verbose -Verbose -Message "Uploading build artifacts"
         $artifactName = 'Win32-OpenSSH'
         Write-Host "##vso[artifact.upload containerfolder=$artifactName;artifactname=$artifactName;]$BuildDestPath"
+        #
+        # Copy unit tests
+        $BuildOutPath = "$(Build.SourcesDirectory)/bin"
+        $UnitTestDestPath = "$(Build.SourcesDirectory)/UnitTests"
+        Copy-UnitTests -UnitTestsSrcDir $BuildOutPath -UnitTestsDestDir $UnitTestDestPath -NativeHostArch x86 -Configuration Release
+        Copy-UnitTests -UnitTestsSrcDir $BuildOutPath -UnitTestsDestDir $UnitTestDestPath -NativeHostArch x64 -Configuration Release
+        #
+        # Upload unit test artifacts
+        Write-Verbose -Verbose -Message "Uploading unit test artifacts"
+        $artifactName = 'UnitTests'
+        Write-Host "##vso[artifact.upload containerfolder=$artifactName;artifactname=$artifactName;]$UnitTestDestPath"
+        #
+        # Upload bash tests config.h file
+        Write-Verbose -Verbose -Message "Uploading config.h file for bash tests"
+        $artifactName = 'ConfigFile'
+        $configFilePath = "$(Build.SourcesDirectory)/config.h"
+        Write-Host "##vso[artifact.upload containerfolder=$artifactName;artifactname=$artifactName;]$configFilePath"
       displayName: Upload Win32-OpenSSH build artifacts
 
 #- stage: Compliance
@@ -91,17 +111,19 @@ stages:
   displayName: Test Win32-OpenSSH
   dependsOn: Build
   jobs:
-  pool:
-    vmImage: windows-latest
-  steps:
-  - powershell: |
+  - job: TestPkgWin32OpenSSH
+    pool:
+      vmImage: windows-latest
+    displayName: Win32-OpenSSH On Windows
+    steps:
+    - powershell: |
         $powerShellPath = Join-Path -Path $env:AGENT_TEMPDIRECTORY -ChildPath 'powershell'
         Invoke-WebRequest -Uri https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/install-powershell.ps1 -outfile ./install-powershell.ps1
         ./install-powershell.ps1 -Destination $powerShellPath
         $vstsCommandString = "vso[task.setvariable variable=PATH]$powerShellPath;$env:PATH"
         Write-Host "sending " + $vstsCommandString
         Write-Host "##$vstsCommandString"
-      displayName: Install PowerShell Core
+      displayName: 'Install PowerShell Core'
 
     - task: DownloadBuildArtifacts@0
       displayName: 'Download build artifacts'
@@ -111,25 +133,81 @@ stages:
         artifactName: Win32-OpenSSH
         downloadPath: '$(System.ArtifactsDirectory)'
 
+    - task: DownloadBuildArtifacts@0
+      displayName: 'Download unit test artifacts'
+      inputs:
+        buildType: current
+        downloadType: single
+        artifactName: UnitTests
+        downloadPath: '$(System.ArtifactsDirectory)'
+
+    - task: DownloadBuildArtifacts@0
+      displayName: 'Download bash test config file artifact'
+      inputs:
+        buildType: current
+        downloadType: single
+        artifactName: ConfigFile
+        downloadPath: '$(System.ArtifactsDirectory)'
+
     - pwsh: |
-        Get-ChildItem -Path "$(System.ArtifactsDirectory)/* -Recurse"
+        $artifactDir = "$(System.ArtifactsDirectory)"
+        Write-Verbose -Verbose -Message "Artifacts directory: $artifactDir"
+        Get-ChildItem -Path $artifactDir -Recurse
       displayName: Capture downloaded artifact directory
 
     - pwsh: |
         Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
-        Install-OpenSSH -SourceDir "$(System.ArtifactsDirectory)/Win32-OpenSSH/x64/Release/*" -OpenSSHDir "$env:SystemDrive/OpenSSH" -NativeHostArch x64 -Configuration Release -Verbose
+        Install-OpenSSH -SourceDir "$(System.ArtifactsDirectory)/Win32-OpenSSH/x64/Release" -OpenSSHDir "$env:SystemDrive/OpenSSH" -Verbose
       displayName: Install Win32-OpenSSH
-  
+
     - pwsh: |
+        Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
+        Install-UnitTests -SourceDir "$(System.ArtifactsDirectory)/UnitTests/x64/Release" -OpenSSHDir "$env:SystemDrive/OpenSSH" -Verbose
+      displayName: Install Unit Tests
+
+    - pwsh: |
+        $configFileSrc = "$(System.ArtifactsDirectory)/ConfigFile/config.h"
+        $configFileDest = "$(Build.SourcesDirectory)"
+        Write-Verbose -Verbose -Message "Copying config file from: ${configFileSrc} to: ${configFileDest}"
+        Copy-Item -Path $configFileSrc -Dest $configFileDest -Force
+      displayName: Copy config file artifact for bash tests
+
+    - pwsh: |
+        $sourceDir = "$(Build.SourcesDirectory)"
+        Write-Verbose -Verbose -Message "Source repo directory: $sourceDir"
+        Get-ChildItem -Path $sourceDir
+      displayName: Capture source repo directory for test
+
+    - pwsh: |
+        $installedOpenSSHDir = "$env:SystemDrive/OpenSSH"
+        Write-Verbose -Verbose -Message "Installed OpenSSH directory: $installedOpenSSHDir"
+        Get-ChildItem -Path $installedOpenSSHDir -Recurse
+      displayName: Capture installed OpenSSH directory
+
+    - pwsh: |
+        # Run OpenSSH tests
         Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
         Invoke-OpenSSHTests -OpenSSHBinPath "$env:SystemDrive/OpenSSH"
+      displayName: Run tests
+
+    - pwsh: |
+        Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
+        #
         # Copy test results to results directory
         $ResultsDirectory = "$(Build.SourcesDirectory)/Win32OpenSSHTestResults"
         Copy-OpenSSHTestResults -ResultsPath $ResultsDirectory
+        #
         # Upload test results artifact
         if (Test-Path -Path $ResultsDirectory)
         {
           $artifactName = 'Win32-OpenSSH-TestResults'
           Write-Host "##vso[artifact.upload containerfolder=$artifactName;artifactname=$artifactName;]$ResultsDirectory"
         }
-      displayName: Run tests and publish results
+      displayName: Upload test results
+      condition: always()
+
+    - pwsh: |
+        Import-Module -Name "$(Build.SourcesDirectory)/contrib/win32/openssh/AzDOBuildTools" -Force
+        Clear-TestEnvironmentSetup
+      displayName: Clean up OpenSSH test environment
+      condition: always()

contrib/win32/openssh/AzDOBuildTools/AzDOBuildTools.psd1

@@ -28,10 +28,12 @@ NestedModules = @(
     '../OpenSSHTestHelper.psm1')
 
 FunctionsToExport = @(
-    'Invoke-AllLocally',
     'Invoke-AzDOBuild',
     'Install-OpenSSH',
     'Invoke-OpenSSHTests',
-    'Copy-OpenSSHTestResults')
-
+    'Copy-OpenSSHTestResults',
+    'Copy-BuildResults',
+    'Copy-UnitTests',
+    'Install-UnitTests',
+    'Clear-TestEnvironmentSetup')
 }