Skip to content

Commit 89b2b1b

Browse files
authored
Remove coverage fail at percentage (#212)
This gets in the way more times that it is useful. If coverage needs to be enforced it should be done within the CI after a compile, not locally.
1 parent d46725d commit 89b2b1b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

noxfile.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
# Control factors for finding pieces of the module
1010
MODULE_NAME = "module_name"
11-
COVERAGE_FAIL_UNDER = "100"
1211
LINT_PATH = "./src"
1312
TESTS_PATH = "./tests"
1413

@@ -82,7 +81,7 @@ def run_tests_with_coverage(session: nox.Session) -> None:
8281
coverage("run", "--parallel-mode", "--module", "pytest", *session.posargs)
8382
else:
8483
coverage("run", "--module", "pytest", *session.posargs)
85-
coverage("report", "--show-missing", f"--fail-under={COVERAGE_FAIL_UNDER}")
84+
coverage("report", "--show-missing")
8685
coverage("html")
8786

8887

@@ -94,7 +93,7 @@ def combine_coverage(session: nox.Session) -> None:
9493
coverage = functools.partial(session.run, "uv", "run", "coverage")
9594

9695
coverage("combine")
97-
coverage("report", "--show-missing", f"--fail-under={COVERAGE_FAIL_UNDER}")
96+
coverage("report", "--show-missing")
9897
coverage("html")
9998
coverage("json")
10099

0 commit comments

Comments
 (0)