Skip to content

bug: new_default_process_async_with_migrations() calls the synchronous migrate callback from async context #18

@lf-

Description

@lf-

I am using an async migration runner which means that I need to run async code inside the migrate callback. Sure, Runtime::block_on, whatever, but that turns out it blows up because it's already being run on a runtime thread.

This is because the migrate callback is called on an async thread (!), which is certainly a bug. The fix to this is to run it in spawn_blocking and/or switch the callback to be itself asynchronous (which is plausibly a pain in the ass because this stuff always is).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions