Fix deprecated size aesthetic #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #37 |
mschilli87
suggested changes
Dec 2, 2025
mschilli87
left a comment
mschilli87
left a comment
There was a problem hiding this comment.
@NovaTutPeter: Please have a look at your patch: Besides changing the line(s) you intended to modify, you added a lot of whitespace to empty lines. I assume this is due to some settings of your text editor but it makes reviewing the PR very difficult and will also interfere with git blame and git bisect calls in the future. I suggest you undo those changes, amend your commit and force-push the branch to keep the history clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed size param to linewidth in geom_tile type calls
Also changed the weeknames.size param default to 3 from 4.5 as this was causing the text to overlap