Add tests

Author: jamiebenstead

spec/features/school_class/listing_school_classes_spec.rb

@@ -155,6 +155,129 @@
     expect(this_class[:unread_feedback_count]).to eq(1)
   end
 
+  it 'returns correct unread_feedback_count across multiple classes with different amounts of unread feedback' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    # Create a second class the student is a member of
+    school_class_2 = create(:school_class, name: 'Second Class', teacher_ids: [teacher.id], school:)
+    create(:class_student, school_class: school_class_2, student_id: student.id)
+
+    # Class 1: Create 2 remixes with unread feedback
+    lesson_one = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+    remix_one = create(:project, school:, lesson: lesson_one, parent: lesson_one.project, remixed_from_id: lesson_one.project.id, user_id: student.id)
+    create(:feedback, school_project: remix_one.school_project, user_id: teacher.id, content: 'Unread 1', read_at: nil)
+
+    lesson_two = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+    remix_two = create(:project, school:, lesson: lesson_two, parent: lesson_two.project, remixed_from_id: lesson_two.project.id, user_id: student.id)
+    create(:feedback, school_project: remix_two.school_project, user_id: teacher.id, content: 'Unread 2', read_at: nil)
+
+    # Class 2: Create 1 remix with unread feedback
+    lesson_three = create(:lesson, school:, school_class: school_class_2, visibility: 'students', user_id: teacher.id)
+    remix_three = create(:project, school:, lesson: lesson_three, parent: lesson_three.project, remixed_from_id: lesson_three.project.id, user_id: student.id)
+    create(:feedback, school_project: remix_three.school_project, user_id: teacher.id, content: 'Unread 3', read_at: nil)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    class_1 = data.find { |c| c[:name] == 'Test School Class' }
+    class_2 = data.find { |c| c[:name] == 'Second Class' }
+
+    expect(class_1[:unread_feedback_count]).to eq(2)
+    expect(class_2[:unread_feedback_count]).to eq(1)
+  end
+
+  it 'returns 0 unread_feedback_count when class has no unread feedback' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    lesson = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+    remix = create(:project, school:, lesson:, parent: lesson.project, remixed_from_id: lesson.project.id, user_id: student.id)
+
+    create(:feedback, school_project: remix.school_project, user_id: teacher.id, content: 'Already read', read_at: Time.current)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    this_class = data.find { |c| c[:name] == 'Test School Class' }
+    expect(this_class[:unread_feedback_count]).to eq(0)
+  end
+
+  it 'returns 0 unread_feedback_count when class has no feedback' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    this_class = data.find { |c| c[:name] == 'Test School Class' }
+    expect(this_class[:unread_feedback_count]).to eq(0)
+  end
+
+  it 'counts projects with unread feedback, not individual feedback items' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    lesson = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+    remix = create(:project, school:, lesson:, parent: lesson.project, remixed_from_id: lesson.project.id, user_id: student.id)
+
+    # Multiple unread feedback on the same project should count as 1
+    create(:feedback, school_project: remix.school_project, user_id: teacher.id, content: 'Unread 1', read_at: nil)
+    create(:feedback, school_project: remix.school_project, user_id: teacher.id, content: 'Unread 2', read_at: nil)
+    create(:feedback, school_project: remix.school_project, user_id: teacher.id, content: 'Unread 3', read_at: nil)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    this_class = data.find { |c| c[:name] == 'Test School Class' }
+    expect(this_class[:unread_feedback_count]).to eq(1)
+  end
+
+  it 'only counts unread feedback on the current students remixes' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    other_student = create(:student, school:)
+    create(:class_student, school_class:, student_id: other_student.id)
+
+    lesson = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+
+    # Current student's remix with unread feedback
+    my_remix = create(:project, school:, lesson:, parent: lesson.project, remixed_from_id: lesson.project.id, user_id: student.id)
+    create(:feedback, school_project: my_remix.school_project, user_id: teacher.id, content: 'My unread', read_at: nil)
+
+    # Other student's remix with unread feedback (should not count)
+    other_remix = create(:project, school:, lesson:, parent: lesson.project, remixed_from_id: lesson.project.id, user_id: other_student.id)
+    create(:feedback, school_project: other_remix.school_project, user_id: teacher.id, content: 'Other unread', read_at: nil)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    this_class = data.find { |c| c[:name] == 'Test School Class' }
+    expect(this_class[:unread_feedback_count]).to eq(1)
+  end
+
+  it 'does not count unread feedback on lessons the student cannot access' do
+    authenticated_in_hydra_as(student)
+    stub_user_info_api_for(teacher)
+
+    # Visible lesson
+    visible_lesson = create(:lesson, school:, school_class:, visibility: 'students', user_id: teacher.id)
+    visible_remix = create(:project, school:, lesson: visible_lesson, parent: visible_lesson.project, remixed_from_id: visible_lesson.project.id, user_id: student.id)
+    create(:feedback, school_project: visible_remix.school_project, user_id: teacher.id, content: 'Visible', read_at: nil)
+
+    # Hidden lesson (visibility: 'teachers')
+    hidden_lesson = create(:lesson, school:, school_class:, visibility: 'teachers', user_id: teacher.id)
+    hidden_remix = create(:project, school:, lesson: hidden_lesson, parent: hidden_lesson.project, remixed_from_id: hidden_lesson.project.id, user_id: student.id)
+    create(:feedback, school_project: hidden_remix.school_project, user_id: teacher.id, content: 'Hidden', read_at: nil)
+
+    get("/api/schools/#{school.id}/classes", headers:)
+    data = JSON.parse(response.body, symbolize_names: true)
+
+    this_class = data.find { |c| c[:name] == 'Test School Class' }
+    expect(this_class[:unread_feedback_count]).to eq(1)
+  end
+
   it 'does not include unread_feedback_count if user is a school-teacher' do
     authenticated_in_hydra_as(teacher)