Skip to content

Commit 7758785

Browse files
authored
Merge pull request #1088 from RcppCore/bugfix/skeleton
correct package skeleton behavior (closes #1087)
2 parents 79565f9 + aa8438a commit 7758785

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed

ChangeLog

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
2020-06-05 Dirk Eddelbuettel <edd@debian.org>
2+
3+
* DESCRIPTION (Version, Date): Roll minor version
4+
* inst/include/Rcpp/config.h: Idem
5+
6+
* R/Rcpp.package.skeleton.R: Remove a remaining NAMESPACE entry for
7+
a temporary function symbol; ensure an exportPattern is set
8+
19
2020-05-18 Dirk Eddelbuettel <edd@debian.org>
210

311
* DESCRIPTION (Version, Date): Roll minor version

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: Rcpp
22
Title: Seamless R and C++ Integration
3-
Version: 1.0.4.11
4-
Date: 2020-05-18
3+
Version: 1.0.4.12
4+
Date: 2020-06-05
55
Author: Dirk Eddelbuettel, Romain Francois, JJ Allaire, Kevin Ushey, Qiang Kou,
66
Nathan Russell, Douglas Bates and John Chambers
77
Maintainer: Dirk Eddelbuettel <edd@debian.org>

R/Rcpp.package.skeleton.R

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (C) 2009 - 2019 Dirk Eddelbuettel and Romain Francois
1+
# Copyright (C) 2009 - 2020 Dirk Eddelbuettel and Romain Francois
22
#
33
# This file is part of Rcpp.
44
#
@@ -28,7 +28,6 @@ Rcpp.package.skeleton <- function(name = "anRpackage", list = character(),
2828

2929
havePkgKitten <- requireNamespace("pkgKitten", quietly=TRUE)
3030

31-
3231
call <- match.call()
3332
call[[1]] <- as.name("package.skeleton")
3433
env <- parent.frame(1)
@@ -116,6 +115,9 @@ Rcpp.package.skeleton <- function(name = "anRpackage", list = character(),
116115
writeLines('importFrom(Rcpp, evalCpp)', ns)
117116
message(" >> added importFrom(Rcpp, evalCpp) directive to NAMESPACE" )
118117
}
118+
if (!any(grepl("^exportPattern", lines))) {
119+
writeLines("exportPattern(\"^[[:alpha:]]+\")", ns)
120+
}
119121
close( ns )
120122

121123
## update the package description help page
@@ -206,6 +208,11 @@ Rcpp.package.skeleton <- function(name = "anRpackage", list = character(),
206208
rm("Rcpp.fake.fun", envir = env)
207209
unlink(file.path(root, "R" , "Rcpp.fake.fun.R"))
208210
unlink(file.path(root, "man", "Rcpp.fake.fun.Rd"))
211+
212+
## cleansing NAMESPACE of fake function entry
213+
lines <- readLines(NAMESPACE)
214+
lines <- lines[!grepl("^export.*fake\\.fun", lines)]
215+
writeLines(lines, NAMESPACE)
209216
}
210217

211218
if (isTRUE(remove_hello_world)) {

inst/include/Rcpp/config.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#define RCPP_VERSION_STRING "1.0.4"
3131

3232
// the current source snapshot
33-
#define RCPP_DEV_VERSION RcppDevVersion(1,0,4,11)
34-
#define RCPP_DEV_VERSION_STRING "1.0.4.11"
33+
#define RCPP_DEV_VERSION RcppDevVersion(1,0,4,12)
34+
#define RCPP_DEV_VERSION_STRING "1.0.4.12"
3535

3636
#endif

0 commit comments

Comments
 (0)