Merge pull request #686 from RcppCore/bugfix/issue685

suggested fix for maacheck (closes #685)

Author: eddelbuettel

ChangeLog

@@ -1,3 +1,8 @@
+2017-04-26  Dirk Eddelbuettel  <edd@debian.org>
+
+        * inst/include/Rcpp/exceptions.h (string_to_try_error): Protect result
+        from Rf_mkString
+
 2017-04-25  Dirk Eddelbuettel  <edd@debian.org>
 
         * R/Attributes.R (.plugins[["cpp11"]]): If R 3.4.0 or newer is used, set

inst/include/Rcpp/exceptions.h

@@ -291,7 +291,8 @@ inline SEXP string_to_try_error( const std::string& str){
     using namespace Rcpp;
 
     #ifndef RCPP_USING_UTF8_ERROR_STRING
-        Rcpp::Shield<SEXP> simpleErrorExpr( Rf_lang2(::Rf_install("simpleError"), Rf_mkString(str.c_str())) );
+        Rcpp::Shield<SEXP> txt(Rf_mkString(str.c_str()));
+        Rcpp::Shield<SEXP> simpleErrorExpr(Rf_lang2(::Rf_install("simpleError"), txt));
         Rcpp::Shield<SEXP> tryError( Rf_mkString( str.c_str() ) );
     #else
         Rcpp::Shield<SEXP> tryError( Rf_allocVector( STRSXP, 1 ) ) ;