Speed up file loading. (#148)

Author: KN4CK3R

ReClass.NET/DataExchange/ReClass/ReClassNetFile.Read.cs

@@ -93,7 +93,7 @@ public void Load(Stream input, ILogger logger)
 				}
 			}
 
-			var classes = new List<Tuple<XElement, ClassNode>>();
+			var classes = new List<(XElement, ClassNode)>();
 
 			var classesElement = document.Root.Element(XmlClassesElement);
 			if (classesElement != null)
@@ -114,21 +114,20 @@ public void Load(Stream input, ILogger logger)
 					{
 						project.AddClass(node);
 
-						classes.Add(Tuple.Create(element, node));
+						classes.Add((element, node));
 					}
 				}
 			}
 
-			foreach (var t in classes)
+			foreach (var (element, classNode) in classes)
 			{
-				var nodes = t.Item1.Elements(XmlNodeElement)
-					.Select(e => CreateNodeFromElement(e, t.Item2, logger))
+				var nodes = element.Elements(XmlNodeElement)
+					.Select(e => CreateNodeFromElement(e, classNode, logger))
 					.Where(n => n != null);
 
-				foreach (var node in nodes)
-				{
-					t.Item2.AddNode(node);
-				}
+				classNode.BeginUpdate();
+				classNode.AddNodes(nodes);
+				classNode.EndUpdate();
 			}
 		}
 

ReClass.NET/Nodes/BaseContainerNode.cs

@@ -8,6 +8,8 @@ public abstract class BaseContainerNode : BaseNode
 	{
 		private readonly List<BaseNode> nodes = new List<BaseNode>();
 
+		private int updateCount;
+
 		/// <summary>The child nodes of the container.</summary>
 		public IReadOnlyList<BaseNode> Nodes => nodes;
 
@@ -122,6 +124,35 @@ private bool TryGetNeighbour(BaseNode node, int offset, out BaseNode neighbour)
 			return true;
 		}
 
+		/// <summary>
+		/// Disables internal events to speed up batch processing.
+		/// <see cref="EndUpdate"/> must be called to restore the functionality.
+		/// </summary>
+		public void BeginUpdate()
+		{
+			updateCount++;
+		}
+
+		/// <summary>
+		/// Enables internal events disabled by <see cref="BeginUpdate"/>.
+		/// </summary>
+		public void EndUpdate()
+		{
+			updateCount = Math.Max(0, updateCount - 1);
+
+			OnNodesUpdated();
+		}
+
+		private void OnNodesUpdated()
+		{
+			if (updateCount == 0)
+			{
+				UpdateOffsets();
+
+				GetParentContainer()?.ChildHasChanged(this);
+			}
+		}
+
 		/// <summary>Replaces the old node with the new node.</summary>
 		/// <param name="oldNode">The old node to replacce.</param>
 		/// <param name="newNode">The new node.</param>
@@ -172,9 +203,7 @@ public void ReplaceChildNode(BaseNode oldNode, BaseNode newNode, ref List<BaseNo
 				}*/
 			}
 
-			UpdateOffsets();
-
-			GetParentContainer()?.ChildHasChanged(this);
+			OnNodesUpdated();
 		}
 
 		/// <summary>
@@ -253,9 +282,7 @@ protected void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 				index++;
 			}
 
-			UpdateOffsets();
-
-			GetParentContainer()?.ChildHasChanged(this);
+			OnNodesUpdated();
 		}
 
 		/// <summary>
@@ -286,9 +313,7 @@ public void AddNode(BaseNode node)
 
 			nodes.Add(node);
 
-			UpdateOffsets();
-
-			GetParentContainer()?.ChildHasChanged(this);
+			OnNodesUpdated();
 		}
 
 		/// <summary>
@@ -312,9 +337,7 @@ public void InsertNode(BaseNode position, BaseNode node)
 
 			nodes.Insert(index, node);
 
-			UpdateOffsets();
-
-			GetParentContainer()?.ChildHasChanged(this);
+			OnNodesUpdated();
 		}
 
 		/// <summary>Removes the specified node.</summary>
@@ -327,9 +350,7 @@ public bool RemoveNode(BaseNode node)
 			var result = nodes.Remove(node);
 			if (result)
 			{
-				UpdateOffsets();
-
-				GetParentContainer()?.ChildHasChanged(this);
+				OnNodesUpdated();
 			}
 			return result;
 		}