Updated the container methods.

Author: KN4CK3R

Nodes/BaseContainerNode.cs

@@ -34,64 +34,47 @@ public int FindNodeIndex(BaseNode node)
 			return Nodes.FindIndex(n => n == node);
 		}
 
-		public virtual BaseNode ReplaceChildNode(BaseNode child, Type nodeType)
+		public bool ReplaceChildNode(BaseNode child, Type nodeType)
 		{
 			Contract.Requires(nodeType != null);
 
-			return ReplaceChildNode(FindNodeIndex(child), nodeType);
+			List<BaseNode> dummy = null;
+			return ReplaceChildNode(child, nodeType, ref dummy);
 		}
 
-		/// <summary>Replaces the child at the specific position with the provided node.</summary>
-		/// <param name="index">Zero-based position.</param>
-		/// <param name="node">The node to add.</param>
-		/// <returns>True if it succeeds, false if it fails.</returns>
-		public virtual BaseNode ReplaceChildNode(int index, Type nodeType)
+		public bool ReplaceChildNode(BaseNode child, Type nodeType, ref List<BaseNode> createdNodes)
 		{
+			Contract.Requires(child != null);
 			Contract.Requires(nodeType != null);
-			Contract.Requires(nodeType.IsSubclassOf(typeof(BaseNode)));
 
-			var node = Activator.CreateInstance(nodeType) as BaseNode;
-
-			node.Intialize();
-
-			if (ReplaceChildNode(index, node))
-			{
-				return node;
-			}
-
-			return null;
+			return ReplaceChildNode(FindNodeIndex(child), nodeType, ref createdNodes);
 		}
 
 		/// <summary>Replaces the child at the specific position with the provided node.</summary>
 		/// <param name="index">Zero-based position.</param>
-		/// <param name="node">The node to add.</param>
+		/// <param name="nodeType">The type of the node.</param>
+		/// <param name="createdNodes">[in,out] A list with the created nodes.</param>
 		/// <returns>True if it succeeds, false if it fails.</returns>
-		public bool ReplaceChildNode(BaseNode child, BaseNode node)
+		public virtual bool ReplaceChildNode(int index, Type nodeType, ref List<BaseNode> createdNodes)
 		{
-			return ReplaceChildNode(FindNodeIndex(child), node);
-		}
+			Contract.Requires(nodeType != null);
+			Contract.Requires(nodeType.IsSubclassOf(typeof(BaseNode)));
 
-		/// <summary>Replaces the child at the specific position with the provided node.</summary>
-		/// <param name="index">Zero-based position.</param>
-		/// <param name="node">The node to add.</param>
-		/// <returns>True if it succeeds, false if it fails.</returns>
-		public virtual bool ReplaceChildNode(int index, BaseNode node)
-		{
-			if (node == null)
-			{
-				return false;
-			}
 			if (index < 0 || index >= nodes.Count)
 			{
 				return false;
 			}
 
 			var oldNode = nodes[index];
 
+			var node = Activator.CreateInstance(nodeType) as BaseNode;
+
+			node.Intialize();
 			node.CopyFromNode(oldNode);
 
+			createdNodes?.Add(node);
+
 			node.ParentNode = this;
-			node.ClearSelection();
 
 			nodes[index] = node;
 
@@ -100,12 +83,12 @@ public virtual bool ReplaceChildNode(int index, BaseNode node)
 
 			if (newSize < oldSize)
 			{
-				InsertBytes(index + 1, oldSize - newSize);
+				InsertBytes(index + 1, oldSize - newSize, ref createdNodes);
 			}
-			else if (newSize > oldSize)
+			/*else if (newSize > oldSize)
 			{
-				//RemoveNodes(index + 1, newSize - oldSize);
-			}
+				RemoveNodes(index + 1, newSize - oldSize);
+			}*/
 
 			return true;
 		}
@@ -117,15 +100,25 @@ public void AddBytes(int size)
 			InsertBytes(nodes.Count, size);
 		}
 
-		public virtual void InsertBytes(BaseNode position, int size)
+		public void InsertBytes(BaseNode position, int size)
 		{
 			InsertBytes(FindNodeIndex(position), size);
 		}
 
 		/// <summary>Inserts <paramref name="size"/> bytes at the specified position.</summary>
 		/// <param name="index">Zero-based position.</param>
 		/// <param name="size">The number of bytes to insert.</param>
-		public virtual void InsertBytes(int index, int size)
+		public void InsertBytes(int index, int size)
+		{
+			List<BaseNode> dummy = null;
+			InsertBytes(index, size, ref dummy);
+		}
+
+		/// <summary>Inserts <paramref name="size"/> bytes at the specified position.</summary>
+		/// <param name="index">Zero-based position.</param>
+		/// <param name="size">The number of bytes to insert.</param>
+		/// <param name="createdNodes">[in,out] A list with the created nodes.</param>
+		public virtual void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
 			if (index < 0 || index > nodes.Count || size == 0)
 			{
@@ -167,6 +160,8 @@ public virtual void InsertBytes(int index, int size)
 
 				nodes.Insert(index, node);
 
+				createdNodes?.Add(node);
+
 				offset += node.MemorySize;
 				size -= node.MemorySize;
 

Nodes/ClassNode.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Diagnostics.Contracts;
 using System.Drawing;
 using System.Linq;
@@ -180,9 +181,9 @@ public void UpdateAddress(MemoryBuffer memory)
 			}
 		}
 
-		public override void InsertBytes(int index, int size)
+		public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
-			base.InsertBytes(index, size);
+			base.InsertBytes(index, size, ref createdNodes);
 
 			ChildHasChanged(null);
 		}
@@ -211,12 +212,12 @@ public override bool RemoveNode(BaseNode node)
 			return removed;
 		}
 
-		public override bool ReplaceChildNode(int index, BaseNode node)
+		public override bool ReplaceChildNode(int index, Type nodeType, ref List<BaseNode> createdNodes)
 		{
-			var replaced = base.ReplaceChildNode(index, node);
+			var replaced = base.ReplaceChildNode(index, nodeType, ref createdNodes);
 			if (replaced)
 			{
-				ChildHasChanged(node);
+				ChildHasChanged(null); //TODO
 			}
 			return replaced;
 		}

Nodes/VTableNode.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using ReClassNET.Memory;
 using ReClassNET.UI;
@@ -92,9 +93,9 @@ public override int CalculateHeight(ViewInfo view)
 			return h;
 		}
 
-		public override bool ReplaceChildNode(int index, BaseNode node) => false;
+		public override bool ReplaceChildNode(int index, Type nodeType, ref List<BaseNode> createdNodes) => false;
 
-		public override void InsertBytes(int index, int size)
+		public override void InsertBytes(int index, int size, ref List<BaseNode> createdNodes)
 		{
 			if (index < 0 || index > nodes.Count || size == 0)
 			{
@@ -118,6 +119,8 @@ public override void InsertBytes(int index, int size)
 
 				nodes.Insert(index, node);
 
+				createdNodes?.Add(node);
+
 				offset += node.MemorySize;
 				size -= node.MemorySize;