General code cleanup.

Author: KN4CK3R

ReClass.NET/AddressParser/DynamicCompiler.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Diagnostics.Contracts;
 using System.Linq.Expressions;
 using System.Reflection;
@@ -92,7 +92,7 @@ private static Expression GenerateMethodBody(IExpression expression, Expression
 							Expression.Condition(
 								Expression.Equal(moduleVariable, Expression.Constant(null)),
 								Expression.Constant(IntPtr.Zero),
-								Expression.MakeMemberAccess(moduleVariable, typeof(Memory.Module).GetProperty(nameof(Memory.Module.Start)))
+								Expression.MakeMemberAccess(moduleVariable, typeof(Memory.Module).GetProperty(nameof(Memory.Module.Start))!)
 							)
 						);
 					}

ReClass.NET/AddressParser/ITokenizer.cs

@@ -1,4 +1,4 @@
-namespace ReClassNET.AddressParser
+namespace ReClassNET.AddressParser
 {
 	public interface ITokenizer
 	{

ReClass.NET/AddressParser/Parser.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 
 namespace ReClassNET.AddressParser
@@ -185,10 +185,9 @@ private IExpression ParseLeaf()
 
 		public static IExpression Parse(string str)
 		{
-			using (var sr = new StringReader(str))
-			{
-				return Parse(new Tokenizer(sr));
-			}
+			using var sr = new StringReader(str);
+
+			return Parse(new Tokenizer(sr));
 		}
 
 		private static IExpression Parse(ITokenizer tokenizer)

ReClass.NET/DataExchange/Scanner/CrySearchFile.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Text;
@@ -72,7 +72,7 @@ public IEnumerable<MemoryRecord> Load(string filePath, ILogger logger)
 									switch (valueTypeStr)
 									{
 										default:
-										case "8":
+										// case "8":
 											record.Encoding = Encoding.UTF8;
 											break;
 										case "9":

ReClass.NET/Debugger/RemoteDebugger.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics.Contracts;
 using System.Linq;
@@ -168,13 +168,11 @@ private List<BreakpointSplit> SplitBreakpoint(IntPtr address, int size)
 						continue;
 					}
 				}
-				if (size >= 1)
-				{
-					splits.Add(new BreakpointSplit { Address = address, Size = 1 });
 
-					address += 1;
-					size -= 1;
-				}
+				splits.Add(new BreakpointSplit { Address = address, Size = 1 });
+
+				address += 1;
+				size -= 1;
 			}
 
 			return splits;

ReClass.NET/Extensions/RichTextBoxExtensions.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Drawing;
 using System.Runtime.InteropServices;
 using System.Windows.Forms;
@@ -16,7 +16,7 @@ public static void SetInnerMargin(this TextBoxBase textBox, int left, int top, i
 		}
 
 		[StructLayout(LayoutKind.Sequential)]
-		private struct RECT
+		private readonly struct RECT
 		{
 			public readonly int Left;
 			public readonly int Top;

ReClass.NET/Forms/ClassSelectionForm.cs

@@ -1,6 +1,5 @@
-using System;
+using System;
 using System.Collections.Generic;
-using System.Data;
 using System.Diagnostics.Contracts;
 using System.Linq;
 using System.Windows.Forms;

ReClass.NET/Forms/EnumListForm.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics.Contracts;
 using System.Linq;
@@ -57,10 +57,9 @@ private void editEnumIconButton_Click(object sender, EventArgs e)
 				return;
 			}
 
-			using (var eef = new EnumEditorForm(@enum))
-			{
-				eef.ShowDialog();
-			}
+			using var eef = new EnumEditorForm(@enum);
+
+			eef.ShowDialog();
 		}
 
 		private void addEnumIconButton_Click(object sender, EventArgs e)
@@ -70,14 +69,13 @@ private void addEnumIconButton_Click(object sender, EventArgs e)
 				Name = "Enum"
 			};
 
-			using (var eef = new EnumEditorForm(@enum))
+			using var eef = new EnumEditorForm(@enum);
+
+			if (eef.ShowDialog() == DialogResult.OK)
 			{
-				if (eef.ShowDialog() == DialogResult.OK)
-				{
-					project.AddEnum(@enum);
+				project.AddEnum(@enum);
 
-					ShowFilteredEnums();
-				}
+				ShowFilteredEnums();
 			}
 		}
 

ReClass.NET/Forms/EnumSelectionForm.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics.Contracts;
 using System.Linq;
@@ -57,10 +57,9 @@ private void editEnumIconButton_Click(object sender, EventArgs e)
 				return;
 			}
 
-			using (var eef = new EnumEditorForm(@enum))
-			{
-				eef.ShowDialog();
-			}
+			using var eef = new EnumEditorForm(@enum);
+
+			eef.ShowDialog();
 		}
 
 		private void addEnumIconButton_Click(object sender, EventArgs e)
@@ -70,14 +69,13 @@ private void addEnumIconButton_Click(object sender, EventArgs e)
 				Name = "Enum"
 			};
 
-			using (var eef = new EnumEditorForm(@enum))
+			using var eef = new EnumEditorForm(@enum);
+
+			if (eef.ShowDialog() == DialogResult.OK)
 			{
-				if (eef.ShowDialog() == DialogResult.OK)
-				{
-					project.AddEnum(@enum);
+				project.AddEnum(@enum);
 
-					ShowFilteredEnums();
-				}
+				ShowFilteredEnums();
 			}
 		}
 

ReClass.NET/Forms/FoundCodeForm.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Data;
 using System.Diagnostics.Contracts;
 using System.Drawing;
@@ -10,7 +10,6 @@
 using ReClassNET.Memory;
 using ReClassNET.Nodes;
 using ReClassNET.UI;
-using ReClassNET.Util;
 
 namespace ReClassNET.Forms
 {