Fixed out of range reads.

KN4CK3R · KN4CK3R · commit de43365a16f4 · 2016-11-30T00:04:22.000+01:00
diff --git a/Memory/Memory.cs b/Memory/Memory.cs
@@ -69,7 +69,7 @@ public byte ReadByte(int offset)
 		{
 			Contract.Requires(offset >= 0);
 
-			if (Offset + offset > data.Length)
+			if (Offset + offset >= data.Length)
 			{
 				return 0;
 			}
@@ -133,6 +133,11 @@ public string ReadPrintableASCIIString(int offset, int length)
 				length = data.Length - Offset - offset;
 			}
 
+			if (length <= 0)
+			{
+				return string.Empty;
+			}
+
 			var sb = new StringBuilder(length);
 			for (var i = 0; i < length; ++i)
 			{

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public byte ReadByte(int offset)`
`69`	`69`	`{`
`70`	`70`	`Contract.Requires(offset >= 0);`
`71`	`71`
`72`		`- if (Offset + offset > data.Length)`
	`72`	`+ if (Offset + offset >= data.Length)`
`73`	`73`	`{`
`74`	`74`	`return 0;`
`75`	`75`	`}`
`@@ -133,6 +133,11 @@ public string ReadPrintableASCIIString(int offset, int length)`
`133`	`133`	`length = data.Length - Offset - offset;`
`134`	`134`	`}`
`135`	`135`
	`136`	`+ if (length <= 0)`
	`137`	`+ {`
	`138`	`+ return string.Empty;`
	`139`	`+ }`
	`140`	`+`
`136`	`141`	`var sb = new StringBuilder(length);`
`137`	`142`	`for (var i = 0; i < length; ++i)`
`138`	`143`	`{`