|
2 | 2 |
|
3 | 3 | Thank you for contributing to RMG-Py! Please take a moment to review our guidelines: |
4 | 4 |
|
5 | | -#### **Did you find a bug?** |
| 5 | +#### **Did you find a bug? Do you want to see a new feature?** |
6 | 6 |
|
7 | | -* ** Example...** |
8 | | - |
9 | | -* Please include in the ISSUES page. |
| 7 | +* Please open an Issue to the corresponding repository: |
| 8 | + * [RMG-Py](https://github.com/ReactionMechanismGenerator/RMG-Py/issues): For functionality of the RMG and Arkane software packages |
| 9 | + * [RMG-database](https://github.com/ReactionMechanismGenerator/RMG-database/issues): For issues related to the data available to RMG |
| 10 | + * [RMG-website](https://github.com/ReactionMechanismGenerator/RMG-website/issues): For issues related to the [RMG website](https://rmg.mit.edu) |
10 | 11 |
|
11 | 12 | * For more detailed information on submitting a bug report and creating an issue, visit our [reporting guidelines](https://example.com). |
12 | 13 |
|
13 | | -#### **Did you write code that fixes a bug?** |
| 14 | +#### **Did you write code that fixes a bug, or adds a new feature?** |
14 | 15 |
|
15 | | -* Open a new GitHub PR to merge into the main branch. |
| 16 | +* Open a new GitHub PR to merge into the main branch. Make sure the PR clearly describes the problem + solution. If applicable, include the relevant issue. |
16 | 17 |
|
17 | | -* Make sure the PR clearly describes the problem + solution. If applicable, include the relevant issue. |
| 18 | +* Your PR must pass unit tests, regression tests, and code coverage, and receive approval from at least one reviewer before it can be merged in. |
18 | 19 |
|
19 | | -* Your PR must pass unit tests, regression tests, and code coverage, and receive approval from a reviewer before it can be merged in. |
| 20 | +* If you wrote a new feature, please add unit tests. If it is a significant new feature, please add a regression test. |
| 21 | + * First, please create an input file that includes your new feature. Ensure `saveEdgeSpecies` is set to `True` so that the edge model will also be saved to a file. If applicable, include diverse sets of input conditions to test compatibility with other features. |
| 22 | + * Generate the reaction mechanism corresponding to the input file. Ensure that the simulation does not take more than 15 minutes maximum. You can reduce simulation times in multiple ways, e.g. by increasing the `toleranceMoveToCore` flag. |
| 23 | + * In the `test/regression` folder, create a new folder with a relevant name, and copy the RMG-Py simulation input file in this folder. Include this new folder in your PR. |
| 24 | + * In `.github/workflows/CI.yml`, edit the two lists of regression tests in the `Regression Tests - Execution` and `Regression Tests - Compare to Baseline` steps to add the name of your folder. Be sure to follow BASH syntax. |
20 | 25 |
|
21 | | -#### **Do you want to see a new feature added?** |
| 26 | + > ** Warning ** |
| 27 | + > This will __fail__ CI because of directory not found errors. This is because the baseline files used for comparison in the regression tests do not exist yet. Your PR will need to be merged by bypassing branch protection restrictions. |
22 | 28 |
|
23 | | -* Suggest your change in the Issues tab. |
24 | 29 |
|
25 | | -#### **Do you have questions?** |
| 30 | +#### **Do you want to contribute to the documentation?** |
26 | 31 |
|
27 | | -* Email us at rmg_dev@mit.edu. |
| 32 | +* Documentation is [hosted here](http://reactionmechanismgenerator.github.io/RMG-Py/) using [Sphinx](https://www.sphinx-doc.org/en/master/). |
28 | 33 |
|
29 | | -#### **Do you want to contribute to the documentation?** |
| 34 | +* The live version of the documentation is hosted on the `gh-pages` branch which is updated upon pushes to the `main` branch of RMG-Py. |
| 35 | + |
| 36 | +* To add new documentation, create or modify `.rst` (reStructuredText) files under the `documentation` directory. For a primer on how to write `.rst` markup, please [check out the Sphinx documentation.](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html) |
30 | 37 |
|
31 | | -* Example here... |
| 38 | +* Please test the documentation on a local build (e.g., via `make html` in the `documentation` directory) before pushing changes. |
32 | 39 |
|
33 | | -### Best practices for PRs: |
| 40 | +#### **Do you have questions?** |
| 41 | + |
| 42 | +* Email us at rmg_dev@mit.edu. |
| 43 | + |
| 44 | +#### **Best practices for PRs** |
34 | 45 |
|
35 | 46 | * Rebase to the main branch before working, to avoid merge conflicts. |
36 | 47 |
|
37 | 48 | * Keep PRs small and aim to merge quickly. |
38 | 49 |
|
39 | | -* Submit a PR only when the code is polished and ready for review. Consider opening a draft PR for work in progress that requires collaborator input. |
| 50 | +* Commits should be specific and as small as required; commit messages should be descriptive and as long as required. Commit messages should explain *why* the change is needed. We recommend following [these guidelines.](https://wiki.openstack.org/wiki/GitCommitMessages) |
40 | 51 |
|
41 | | -* For complex, multi-step PRs, consider opening "megathread" PRs pointing to the main branch. Then, create other PRs that merge into the "megathread" PR branch. This helps divide the review process into smaller chunks. |
| 52 | +* Submit a PR only when the code is polished and ready for review. Consider opening a draft PR for work in progress that requires collaborator input. |
42 | 53 |
|
| 54 | +* Please follow the [PEP8 Python style guide.](https://peps.python.org/pep-0008/) |
43 | 55 |
|
44 | 56 | Thank you! |
| 57 | + |
45 | 58 | RMG Developers |
0 commit comments