Skip to content

Commit 21f7c8a

Browse files
committed
Fix slow editor load on large projects (v2)
1 parent 2be730a commit 21f7c8a

10 files changed

+224
-118
lines changed

core/io/resource_importer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ bool ResourceFormatImporter::are_import_settings_valid(const String &p_path) con
507507

508508
for (int i = 0; i < importers.size(); i++) {
509509
if (importers[i]->get_importer_name() == pat.importer) {
510-
if (!importers[i]->are_import_settings_valid(p_path)) { //importer thinks this is not valid
510+
if (!importers[i]->are_import_settings_valid(p_path, pat.metadata)) { //importer thinks this is not valid
511511
return false;
512512
}
513513
}

core/io/resource_importer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ class ResourceImporter : public RefCounted {
153153
virtual void import_threaded_end() {}
154154

155155
virtual Error import_group_file(const String &p_group_file, const HashMap<String, HashMap<StringName, Variant>> &p_source_file_options, const HashMap<String, String> &p_base_paths) { return ERR_UNAVAILABLE; }
156-
virtual bool are_import_settings_valid(const String &p_path) const { return true; }
156+
virtual bool are_import_settings_valid(const String &p_path, const Dictionary &p_meta) const { return true; }
157157
virtual String get_import_settings_string() const { return String(); }
158158
};
159159

drivers/unix/file_access_unix.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@ uint64_t FileAccessUnix::_get_modified_time(const String &p_file) {
294294
if (!err) {
295295
return status.st_mtime;
296296
} else {
297-
WARN_PRINT("Failed to get modified time for: " + p_file);
298297
return 0;
299298
}
300299
}

drivers/windows/file_access_windows.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,6 @@ uint64_t FileAccessWindows::_get_modified_time(const String &p_file) {
445445
}
446446
}
447447

448-
print_verbose("Failed to get modified time for: " + p_file);
449448
return 0;
450449
}
451450

0 commit comments

Comments
 (0)