Merge pull request #97414 from AThousandShips/code_highlight_fix

akien-mga · akien-mga · commit 56d50c30a295 · 2024-09-26T18:45:38.000+02:00
Fix editing of some properties in `CodeHighlighter`
diff --git a/scene/resources/syntax_highlighter.cpp b/scene/resources/syntax_highlighter.cpp
@@ -442,7 +442,6 @@ Color CodeHighlighter::get_keyword_color(const String &p_keyword) const {
 }
 
 void CodeHighlighter::set_keyword_colors(const Dictionary p_keywords) {
-	keywords.clear();
 	keywords = p_keywords;
 	clear_highlighting_cache();
 }
@@ -476,7 +475,6 @@ Color CodeHighlighter::get_member_keyword_color(const String &p_member_keyword)
 }
 
 void CodeHighlighter::set_member_keyword_colors(const Dictionary &p_member_keywords) {
-	member_keywords.clear();
 	member_keywords = p_member_keywords;
 	clear_highlighting_cache();
 }

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,6 @@ Color CodeHighlighter::get_keyword_color(const String &p_keyword) const {`
`442`	`442`	`}`
`443`	`443`
`444`	`444`	`void CodeHighlighter::set_keyword_colors(const Dictionary p_keywords) {`
`445`		`- keywords.clear();`
`446`	`445`	`keywords = p_keywords;`
`447`	`446`	`clear_highlighting_cache();`
`448`	`447`	`}`
`@@ -476,7 +475,6 @@ Color CodeHighlighter::get_member_keyword_color(const String &p_member_keyword)`
`476`	`475`	`}`
`477`	`476`
`478`	`477`	`void CodeHighlighter::set_member_keyword_colors(const Dictionary &p_member_keywords) {`
`479`		`- member_keywords.clear();`
`480`	`478`	`member_keywords = p_member_keywords;`
`481`	`479`	`clear_highlighting_cache();`
`482`	`480`	`}`