Merge pull request #98160 from Rindbee/change-the-parent-node-of-EditorHelpBitTooltip

Repiteo · Repiteo · commit 91bd80de51ad · 2024-11-18T09:23:52.000-06:00
Add `EditorHelpBitTooltip` as a child of `p_target` to avoid jitter
diff --git a/editor/editor_help.cpp b/editor/editor_help.cpp
@@ -3868,7 +3868,7 @@ void EditorHelpBitTooltip::show_tooltip(EditorHelpBit *p_help_bit, Control *p_ta
 	EditorHelpBitTooltip *tooltip = memnew(EditorHelpBitTooltip(p_target));
 	p_help_bit->connect("request_hide", callable_mp(tooltip, &EditorHelpBitTooltip::_safe_queue_free));
 	tooltip->add_child(p_help_bit);
-	p_target->get_viewport()->add_child(tooltip);
+	p_target->add_child(tooltip);
 	p_help_bit->update_content_height();
 	tooltip->popup_under_cursor();
 }

Original file line number	Diff line number	Diff line change
`@@ -3868,7 +3868,7 @@ void EditorHelpBitTooltip::show_tooltip(EditorHelpBit p_help_bit, Control p_ta`
`3868`	`3868`	`EditorHelpBitTooltip *tooltip = memnew(EditorHelpBitTooltip(p_target));`
`3869`	`3869`	`p_help_bit->connect("request_hide", callable_mp(tooltip, &EditorHelpBitTooltip::_safe_queue_free));`
`3870`	`3870`	`tooltip->add_child(p_help_bit);`
`3871`		`- p_target->get_viewport()->add_child(tooltip);`
	`3871`	`+ p_target->add_child(tooltip);`
`3872`	`3872`	`p_help_bit->update_content_height();`
`3873`	`3873`	`tooltip->popup_under_cursor();`
`3874`	`3874`	`}`