Merge pull request #100670 from hpvb/fix-100666

akien-mga · akien-mga · commit 91e72100e961 · 2024-12-20T23:57:43.000+01:00
Don't recursively call `_update_tree`
diff --git a/editor/gui/scene_tree_editor.cpp b/editor/gui/scene_tree_editor.cpp
@@ -369,7 +369,7 @@ void SceneTreeEditor::_update_node_subtree(Node *p_node, TreeItem *p_parent, boo
 			item->set_selectable(0, false);
 			item->deselect(0);
 			if (selected == p_node) {
-				set_selected(nullptr, false);
+				selected = nullptr;
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ void SceneTreeEditor::_update_node_subtree(Node p_node, TreeItem p_parent, boo`
`369`	`369`	`item->set_selectable(0, false);`
`370`	`370`	`item->deselect(0);`
`371`	`371`	`if (selected == p_node) {`
`372`		`- set_selected(nullptr, false);`
	`372`	`+ selected = nullptr;`
`373`	`373`	`}`
`374`	`374`	`}`
`375`	`375`	`}`